File colors #282
File colors #282
Conversation
Looks like GNU's C++ compiler doesn't like `m[k] = v`, since it slows
down the compile time to a crawl. Using `std::make_pair(k, v)` or `{k,
v}` seems to not cause any issues, and the compile speed doesn't seem to
be affected at all.
|
I think maybe the way to go is to support a new command line argument (maybe If the name contains a dot it could be treated as matching the whole filename instead of the extension. Could potentially also allow including the path as well for giving a colour to a specific file. There could also be an option As for languages sharing extensions I'm not sure it can handle that. You need to use a file-colours file appropriate to the language of the project I guess. |
While I would love that option, especially if we consider the nature of having hard-coded colors, I think most people would prefer convenience in order to actually use this feature. Over the years, I [personally] saw two modifications (Go, Crystal) and new additions (Zig, Fennel, Mint) to the Linguist project. I wrote a Go program that automates parsing this file, so we'll just need to decide which duplicates to remove (there are slightly over 100 of them). One way to have both options, I think, would be to make How does that sound? Unless I'm forgetting something, it sounds like that should cover all use-cases.
Got it! I believe I have an idea how to implement that. |
|
I'm not sure about that command line argument, maybe I think we could distribute the Linguist custom colour file with Gource and load it with the same function as custom colour files. Could possibly have a command line option that gives a language hint that in this case could resolve ambiguity with file extensions. The file colour file could have an optional last column which is the language? Might be overkill. Not sure how big this issue actually is. Some of the duplicates have the same colour so not actually duplicates. Could just exclude the duplicates as a first pass. |
Hi Andrew,
I implemented file colors based on GitHub's Linguist project. However, there are three issues that I've left unresolved:
Some languages have shared file extensions, so we'll need to implement some kind of override or simple language detection.
How should we handle files that require full base name (e.g.
go.sum/go.mod) for colors to be applied to them?How should we handle files that have extensions and no colors (e.g. all image formats) assigned to them?
Before/after screenshots of Gource and one of my projects. Some file colors might look off, but this is because I left duplicate keys in the map.
References #104.
P.S. C++ isn't my preferred language, but please let me know if I can do something better. I just explored/hacked on Gource for a few days, and this is the result!