Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

Dependencies Cleanup #53

Open
jolanglinais opened this issue Apr 30, 2020 · 6 comments
Open

Dependencies Cleanup #53

jolanglinais opened this issue Apr 30, 2020 · 6 comments
Assignees
Labels
Package: Contract Editor 💻 Type: Dependencies 🏠 Pull requests that update a dependency file

Comments

@jolanglinais
Copy link
Member

Need to take a hard look at all our dependencies. This library is pretty big.

This impacts security, development workflow (slow builds), and page load times.

@jolanglinais jolanglinais pinned this issue May 4, 2020
@jolanglinais jolanglinais transferred this issue from accordproject/cicero-ui May 13, 2020
@jolanglinais jolanglinais added Help Wanted 🆘 Extra attention is needed Package: Contract Editor 💻 Type: Dependencies 🏠 Pull requests that update a dependency file Type: Enhancement ✨ Improvement to process or efficiency Type: Need Investigation 🔬 labels May 13, 2020
@aashrafh
Copy link

I want to work on it. I understood that it needs someone to investigate the code and make sure that all of these dependencies are used and suggest a better/lighter alternative, right?

@jolanglinais
Copy link
Member Author

That's correct @aashrafh, and some of the dependencies may be unused.

@aashrafh aashrafh removed their assignment Jan 15, 2021
@Cronus1007
Copy link
Contributor

Cronus1007 commented Mar 11, 2021

@irmerk Shall I start work upon this issue.This package has the dependencies as stale like npm-run-all and rimraf.

@jolanglinais
Copy link
Member Author

Could you please outline what you plan to change here before opening a PR?

@Cronus1007
Copy link
Contributor

@irmerk I have laid out the same plan for this package as well. Check this out #52 (comment)

@jolanglinais
Copy link
Member Author

Sorry for the delay, I think this makes sense @Cronus1007

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Package: Contract Editor 💻 Type: Dependencies 🏠 Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants