Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo signal should not stop on Lakes #67

Open
hekow opened this issue Mar 28, 2016 · 1 comment
Open

Echo signal should not stop on Lakes #67

hekow opened this issue Mar 28, 2016 · 1 comment
Assignees

Comments

@hekow
Copy link
Contributor

hekow commented Mar 28, 2016

When we echo on a lake, it return found ground at 0 range.
But in reality there is nothing to stop the signal, so it should keep going.

In order to obtain this behavior there is only one line to change:
line 262 of Game.scala
if (! biomes.contains(Biomes.OCEAN)) {
//stop
to
if (! biomes.contains(Biomes.OCEAN)&&! biomes.contains(Biomes.LAKE) {

@mosser mosser self-assigned this Mar 28, 2016
@mosser
Copy link
Member

mosser commented Mar 28, 2016

Thanks for reporting this bug. I'll fix it in the next sprint dedicated to Island, not before this summer. Your fix seems to do the job, but as this feature os part of the engine it must be carefully tested. We need to exhibit a unit test that reproduce the issue (which might actually be more complicated that fixing the code) to ensure that the action behavior is the right one and will not trigger any side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants