Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control scheme consistency with other tools #105

Closed
willhansen opened this issue Dec 8, 2024 · 3 comments
Closed

Control scheme consistency with other tools #105

willhansen opened this issue Dec 8, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@willhansen
Copy link

When typing in the replacement text, there are some control conventions that would be more consistent with other tools.

  • <enter> -> Confirmation
  • <C-u> -> Clear input
  • <C-c> -> Exit tool
  • \n -> Insert newline

Some others too, but these ones feel like the main ones.

Makes me wonder if there's a standard text input field plugin-type-thing out there for this sort of thing.

@acheronfail
Copy link
Owner

I love the <C-u> and <C-c> suggestions, that's something we should definitely do.

Regarding <enter>, this isn't the first suggestion (see #106).
I'm hesitant to have \n insert a newline: what if the user wishes to insert the literal characeters \ n?

As long as it's something that's fairly common and not entire unexpected I'm happy... But I don't want to compromise on functionality either.

@acheronfail
Copy link
Owner

acheronfail commented Feb 12, 2025

Partially fixed (enter, <C-u> and <C-c>) in 0.16.0

@acheronfail
Copy link
Owner

Actually, reviewing this issue again, I think 0.16.0 has applied all the suggestions here, so closing this (re-open if I missed anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants