-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove registerable
strategy from our generated Devise User model
#360
Comments
I also think the comment should mention that if you do turn on |
If we disable the The options I see are
Thoughts? cc @joshmcarthur |
@eoinkelly for a client project where this came up, I disabled the registration routes and removed the registerable strategy from the model, then added my own routes wrapped in That feels like something we could quite easily make the default? |
@joshmcarthur What does that buy us over just disabling the routes? |
We want to use devise code to handle password changing etc. We have decided to implement this using @joshmcarthur suggestion above
|
In nearly all of our apps, we don't have open registrations the way Devise adds by default. This means that unless a developer specifically disables or removes this strategy, we risk leaving registrations open when we do not intend to.
A safer default would be to disable this strategy by commenting it out. Those apps that need registration can simply re-add it, as they would for any other disabled-by-default strategy. The bulk of our apps that do not need it will not have it enabled.
The text was updated successfully, but these errors were encountered: