Enable Rails-Turbo #497
Merged
Enable Rails-Turbo #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoinkelly
requested review from
lukeify,
halles,
joshmcarthur,
robotdana,
robramsaynz,
JacobBriggsAckama,
brooke-m and
hopkincame
G-Rath
requested changes
Sep 22, 2023
Comment on lines
+104
to
+107
| # Setup Turbo | ||
| yarn_add_dependencies %w[ | ||
| @hotwired/turbo-rails | ||
| ] |
There was a problem hiding this comment.
issue: this is installing the same package twice
Suggested change
| # Setup Turbo | |
| yarn_add_dependencies %w[ | |
| @hotwired/turbo-rails | |
| ] |
There was a problem hiding this comment.
Doh. Typo from me. I won't keep your suggestion because I wanted Turbo to be in it's own part of the file but I will remove the duplication
There was a problem hiding this comment.
ok but that means we're running yarn install yet again which has it re-do a bunch more work - I know its not the biggest deal in the context of the template, but imo its still silly when the line immediately before it is doing an install...
I'll not block over it though 🤷
eoinkelly
commented
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484