Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS13 Compatibility #89

Open
JulzPolz opened this issue Oct 1, 2019 · 6 comments
Open

iOS13 Compatibility #89

JulzPolz opened this issue Oct 1, 2019 · 6 comments

Comments

@JulzPolz
Copy link

JulzPolz commented Oct 1, 2019

There are a few new warnings as a result of iOS13.

The main culprit seems to be...
'SecTrustEvaluate' is deprecated: first deprecated in iOS 13.0

Screenshots of the code with these warnings...
Screenshot 2019-10-01 at 15 43 46
Screenshot 2019-10-01 at 15 43 25

@JulzPolz
Copy link
Author

JulzPolz commented Oct 3, 2019

Any thoughts on this @acmacalister ? Its just generally much better to have no warnings in the code so that developers are able to spot new warnings during coding instantly without having to read through a list of existing warnings. Thanks.

@JulzPolz
Copy link
Author

Thanks for fixing this. Any idea when it will be pulled into master? Thanks.

@JulzPolz
Copy link
Author

JulzPolz commented Nov 1, 2019

@ddaddy any news for when this will be hitting master?

@ddaddy
Copy link

ddaddy commented Nov 1, 2019

Sorry, I'm not the owner of this. I submitted the pull request but @acmacalister needs to pull it.

@JulzPolz
Copy link
Author

JulzPolz commented Nov 1, 2019

Ok cool. Will wait for @acmacalister to merge into master then.

@themartorana
Copy link

There are 11 open pull requests open since 2015, and no commit on this repo for over 2 years. I'm guessing it's a dead repo.

Interestingly, Sonos just forked it: https://github.com/sonos/jetfire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants