Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dns_gandi_livedns.sh] Shouldn't store GANDI_LIVEDNS_TOKEN / GANDI_LIVEDNS_KEY into the account conf file #6081

Open
pini-gh opened this issue Nov 4, 2024 · 2 comments

Comments

@pini-gh
Copy link

pini-gh commented Nov 4, 2024

The script dnsapi/dns_gandi_livedns.sh shouldn't save GANDI_LIVEDNS_TOKEN nor GANDI_LIVEDNS_KEY into the account configuration file.

Because afterward any new value for the related variable will be ignored, because overridden when sourcing the account.conf file.

To reproduce this behavior:

  1. Try to issue a certificate using a wrong Gandi LiveDNS token
$ GANDI_LIVEDNS_TOKEN=whatever acme.sh --issue --server https://acme-v02.api.letsencrypt.org/directory  --dns dns_gandi_livedns --force --domain example.org```
  1. At this stage the value of GANDI_LIVEDNS_TOKEN is stored into the account.conf file:
grep TOKEN ~/.acme.sh/account.conf 
GANDI_LIVEDNS_TOKEN='whatever'
  1. Try again to issue a certificate using a fixed token
GANDI_LIVEDNS_TOKEN=<token_fixed> acme.sh --issue --server https://acme-v02.api.letsencrypt.org/directory  --dns dns_gandi_livedns --force --domain example.org
  1. Unfortunately the current token is overridden when reading the old one from the account.conf which isn't updated:
grep TOKEN ~/.acme.sh/account.conf 
GANDI_LIVEDNS_TOKEN='whatever'

It is impossible to set the token correctly unless it is manually removed from account.conf.

Copy link

github-actions bot commented Nov 4, 2024

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

@pini-gh
Copy link
Author

pini-gh commented Nov 4, 2024

As I understand it there is no need for a log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant