From 5789e80d741462f36fc2b1949a965550c051444d Mon Sep 17 00:00:00 2001
From: IIIPr0t0typ3III <f.sch.prototype@gmail.com>
Date: Fri, 5 Jul 2024 18:43:11 +0200
Subject: [PATCH 1/4] Fixed a bug where the zone_id was corrupted for domains
 containing the string 'id' dns_dynv6.sh

This will now search for `"id:"` instead of `id` and therefore will only find the id field and not any other field containing the sub-string 'id'
---
 dnsapi/dns_dynv6.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dnsapi/dns_dynv6.sh b/dnsapi/dns_dynv6.sh
index 8b94dae754..7ef66bf3f4 100644
--- a/dnsapi/dns_dynv6.sh
+++ b/dnsapi/dns_dynv6.sh
@@ -206,7 +206,7 @@ _get_zone_id() {
     return 1
   fi
 
-  zone_id="$(echo "$response" | tr '}' '\n' | grep "$selected" | tr ',' '\n' | grep id | tr -d '"')"
+  zone_id="$(echo "$response" | tr '}' '\n' | grep "$selected" | tr ',' '\n' | grep '"id":' | tr -d '"')"
   _zone_id="${zone_id#id:}"
   _debug "zone id: $_zone_id"
 }

From a2bc79ddd51c6ecdd831a105530ad5e8618ff346 Mon Sep 17 00:00:00 2001
From: Felix Schmidt <felix.schmidt@fau.de>
Date: Sun, 7 Jul 2024 12:30:15 +0200
Subject: [PATCH 2/4] Fixed a bug where trying to add entries where the
 fulldomain contains upper case characters would not be accepted (dynv6 API
 rejects those).

Now the fulldomain will be cast to lowercase first which should not make
any difference since DNS is case insensitive.
---
 dnsapi/dns_dynv6.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dnsapi/dns_dynv6.sh b/dnsapi/dns_dynv6.sh
index 7ef66bf3f4..a8bb2adfe1 100644
--- a/dnsapi/dns_dynv6.sh
+++ b/dnsapi/dns_dynv6.sh
@@ -16,8 +16,8 @@ dynv6_api="https://dynv6.com/api/v2"
 # Please Read this guide first: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide
 #Usage: dns_dynv6_add  _acme-challenge.www.domain.com  "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
 dns_dynv6_add() {
-  fulldomain=$1
-  txtvalue=$2
+  fulldomain=$(echo "$1" | tr 'A-Z' 'a-z')
+  txtvalue="$2"
   _info "Using dynv6 api"
   _debug fulldomain "$fulldomain"
   _debug txtvalue "$txtvalue"
@@ -50,8 +50,8 @@ dns_dynv6_add() {
 #Usage: fulldomain txtvalue
 #Remove the txt record after validation.
 dns_dynv6_rm() {
-  fulldomain=$1
-  txtvalue=$2
+  fulldomain=$(echo "$1" | tr 'A-Z' 'a-z')
+  txtvalue="$2"
   _info "Using dynv6 API"
   _debug fulldomain "$fulldomain"
   _debug txtvalue "$txtvalue"

From ab86e056a26112ca5ef145c60cc28afbd0ca2baa Mon Sep 17 00:00:00 2001
From: Felix Schmidt <felix.schmidt@fau.de>
Date: Sun, 7 Jul 2024 13:02:47 +0200
Subject: [PATCH 3/4] Changed A-Z and a-z to [:upper:] and [:lower:] from last
 commit to comply with requested standards.

This does not change any functionality in this special case but the
request for [:upper:] and [:lower:] makes a lot of sense in general.
---
 dnsapi/dns_dynv6.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dnsapi/dns_dynv6.sh b/dnsapi/dns_dynv6.sh
index a8bb2adfe1..b15fe36f54 100644
--- a/dnsapi/dns_dynv6.sh
+++ b/dnsapi/dns_dynv6.sh
@@ -16,7 +16,7 @@ dynv6_api="https://dynv6.com/api/v2"
 # Please Read this guide first: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide
 #Usage: dns_dynv6_add  _acme-challenge.www.domain.com  "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
 dns_dynv6_add() {
-  fulldomain=$(echo "$1" | tr 'A-Z' 'a-z')
+  fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]')
   txtvalue="$2"
   _info "Using dynv6 api"
   _debug fulldomain "$fulldomain"
@@ -50,7 +50,7 @@ dns_dynv6_add() {
 #Usage: fulldomain txtvalue
 #Remove the txt record after validation.
 dns_dynv6_rm() {
-  fulldomain=$(echo "$1" | tr 'A-Z' 'a-z')
+  fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]')
   txtvalue="$2"
   _info "Using dynv6 API"
   _debug fulldomain "$fulldomain"

From dd582c030610446606a7789d58ecd06315aea89b Mon Sep 17 00:00:00 2001
From: Felix Schmidt <felix.schmidt@fau.de>
Date: Tue, 23 Jul 2024 12:59:42 +0200
Subject: [PATCH 4/4] Changed the direct call of `tr` to cast to lower case to
 the function `_lower_case` which is already provided.

---
 dnsapi/dns_dynv6.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dnsapi/dns_dynv6.sh b/dnsapi/dns_dynv6.sh
index b15fe36f54..6fbb23ca48 100644
--- a/dnsapi/dns_dynv6.sh
+++ b/dnsapi/dns_dynv6.sh
@@ -16,7 +16,7 @@ dynv6_api="https://dynv6.com/api/v2"
 # Please Read this guide first: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide
 #Usage: dns_dynv6_add  _acme-challenge.www.domain.com  "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
 dns_dynv6_add() {
-  fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]')
+  fulldomain="$(echo "$1" | _lower_case)"
   txtvalue="$2"
   _info "Using dynv6 api"
   _debug fulldomain "$fulldomain"
@@ -50,7 +50,7 @@ dns_dynv6_add() {
 #Usage: fulldomain txtvalue
 #Remove the txt record after validation.
 dns_dynv6_rm() {
-  fulldomain=$(echo "$1" | tr '[:upper:]' '[:lower:]')
+  fulldomain="$(echo "$1" | _lower_case)"
   txtvalue="$2"
   _info "Using dynv6 API"
   _debug fulldomain "$fulldomain"