Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings.php permissions #68

Open
loopy3025 opened this issue Aug 6, 2024 · 5 comments
Open

settings.php permissions #68

loopy3025 opened this issue Aug 6, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@loopy3025
Copy link

loopy3025 commented Aug 6, 2024

Describe the bug
On composer install, drupal-recommended-settings runs /home/ide/project/vendor/bin/drush drs:init:settings. When it does this, permissions on settings.php change from 644 to 755.

To Reproduce

chmod 644 docroot/sites/default/settings.php
rm -rf vendor
git checkout composer.lock
composer install

Expected behavior
Permissions on settings.php should be 644 on a drupal website.

Environment
Happening both locally and during pipelines ci, so ci fails on a check dirty.

Additional context
I have tried adding the file to file-mapping in composer, but that also doesn't work. The chmod still happens.

"extra": {
        "drupal-scaffold": {
            "locations": {
                "web-root": "./docroot"
            },
            "file-mapping": {
                "[web-root]/sites/default/settings.php": false
            }
        },
}

Although I really don't want to do this anyways because it wouldn't capture future patches to settings.php.

For now I will add a hook that re-chmods the file but this is weird.

@loopy3025 loopy3025 added the bug Something isn't working label Aug 6, 2024
@loopy3025
Copy link
Author

loopy3025 commented Aug 7, 2024

I am wondering if this is an intentional aspect of drupal-recommended-settings and I should just let it happen.

I have noticed, when ssh into these sites, that some seem to have changed the permissions to -r--r--r--. On the site I am currently working on, the settings.php file has not been included in the deployment artefact at all. This is most perplexing.

@loopy3025
Copy link
Author

loopy3025 commented Aug 8, 2024

I've gone and added settings.php to the gitignore then added git add -f docroot/sites/default/settings.php to the build artefact step in pipelines. I am 99% sure the file is being added during composer install. The file is still not in the build artefact. I am really not sure what's going on here.

@loopy3025
Copy link
Author

loopy3025 commented Aug 8, 2024

Pipelines is definitely adding the file to the commit. It just isn't making it to the build artefact itslef somehow.

Screenshot 2024-08-08 at 4 27 13 PM Screenshot 2024-08-08 at 4 28 34 PM

@loopy3025
Copy link
Author

As it turns out, the missing settings file is an issue with Acquia's ODE environments.

However, I still think it's weird that the settings.php file gets chmod to 777 during composer install.

@loopy3025
Copy link
Author

We have decided to add the docroot/sites/default/settings.php to our gitignore file and just let drupal-recommended-settings do whatever it wants there. The file does get committed to the build artefact without the need to add -f to the git add command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant