Python tests 2: Streaming boogaloo #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LD_TESTING` cmake option.
aliddell
force-pushed
the
python-tests-2
branch
from
a884c62 to
eee52c1
Compare
jeskesen
reviewed
Oct 28, 2024
pyproject.toml
Outdated
| ] | ||
|
|
||
| [tool.black] | ||
| target-version = ['py39', 'py310', 'py311'] |
There was a problem hiding this comment.
I just want to point out that Ubuntu 24.04 uses v3.12. It isn't critical for me, as I'm using C++, but wanted you to know in case there was a user-base that was interested.
| ), | ||
| ], | ||
| ) | ||
| @pytest.mark.skip(reason="Temporary; needs debugging") |
There was a problem hiding this comment.
I just want to confirm that we're skipping this test (and thus it will not be reviewed)?
src/streaming/zarr.stream.cpp
Outdated
| @@ -882,7 +881,8 @@ ZarrStream_s::write_multiscale_frames_(const std::byte* data, | |||
| return; | |||
| } | |||
|
|
|||
| std::function<std::byte*(const std::byte*, size_t&, size_t&, size_t&)> scale; | |||
| std::function<std::byte*(const std::byte*, size_t&, size_t&, size_t&)> | |||
| scale; | |||
There was a problem hiding this comment.
trivial: this seems less readable than what it was before.
There was a problem hiding this comment.
Artifact of automatically formatting on save, I guess.
jeskesen
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyZarrStreamSettings::__repr__definition