-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge): testimonials + bridge now sections #17
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two nits
<> | ||
Yeah, I bridge a lot, noticed @BungeeExchange routes were giving me | ||
@AcrossProtocol most of the time, so just started to use it as my default bridge | ||
(minimizing risk is my primary concern when bridging). | ||
<br /> | ||
<br /> | ||
Transfers are incredibly fast and cheap. Great work! | ||
</> | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'm not a huge fan of having markdown for each individual tweet. Not sure if there's a better solution, but it feels like it may be unwieldy if we increase the number of tweets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I am also not a big fan of this. But that's the best I could come up with. Especially with the Twitter API being highly limited (free version at least)
remotePatterns: [ | ||
{ | ||
protocol: "https", | ||
hostname: "pbs.twimg.com", | ||
pathname: "**", | ||
}, | ||
], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Closes ACX-1890 and ACX-1891