Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service URLs passed via secrets #492

Open
HenkvanDyk opened this issue Aug 16, 2024 · 1 comment
Open

Support service URLs passed via secrets #492

HenkvanDyk opened this issue Aug 16, 2024 · 1 comment
Labels

Comments

@HenkvanDyk
Copy link

Is your feature request related to a problem? Please describe.
Currently all information related to services such as postgres, elasticsearch, kafka and zookeper are being injected as secrets, including the urls.
This allows adding kafka brokers or moving databases without needing my charts using the services needing to be updated, however the Datahub charts expect theses values to be injected in the template itself.

Describe the solution you'd like
I'd optionally like to set urls by secret reference by allowing a user to pass the secret name and key if it exists, otherwise they can "hardcode" it in the values.yaml.

Describe alternatives you've considered
I could fork the charts, but I'd prefer to keep up to date with changes on datahub charts.

Additional context
Examples of these urls which can be passed as secretKeyRefs:

bootstrap:
server: "prerequisites-kafka:9092"
zookeeper:
server: "prerequisites-zookeeper:2181"

Copy link

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant