Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting OIDC providers other than Google, Azure, Okta #498

Open
chgl opened this issue Aug 30, 2024 · 1 comment
Open

Allow setting OIDC providers other than Google, Azure, Okta #498

chgl opened this issue Aug 30, 2024 · 1 comment
Labels

Comments

@chgl
Copy link

chgl commented Aug 30, 2024

Is your feature request related to a problem? Please describe.

In https://github.com/acryldata/datahub-helm/blob/master/charts/datahub/subcharts/datahub-frontend/templates/deployment.yaml#L243 only google, okta, and azure are valid OIDC providers.
It would be great if arbitray providers can be specified as well.

Describe the solution you'd like

Allow setting an other provider with a custom discovery url.

Describe alternatives you've considered

Setting everything using extraEnv should work alternatively.

Additional context

I'd be happy to contribute this change!

Copy link

This issue is stale because it has been open for 30 days with no activity. If you believe this is still an issue on the latest DataHub release please leave a comment with the version that you tested it with. If this is a question/discussion please head to https://slack.datahubproject.io. For feature requests please use https://feature-requests.datahubproject.io

@github-actions github-actions bot added the stale label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant