click-odoo-uninstall, search for installed module only

[GSLabIt]

Hi there,

any chance to search for installed module only? It will prevent error if module is not installed.

from:
modules = env["ir.module.module"].search([("name", "in", module_names)])

to:
modules = env["ir.module.module"].search([("name", "in", module_names),('state','=','installed')])

in

click-odoo-contrib/click_odoo_contrib/uninstall.py

Line 13 in 0a585ef

modules = env["ir.module.module"].search([("name", "in", module_names)])

[sbidoul]

Hi! What error do you observe? Should we include modules to upgrade too?

[GSLabIt]

Hi! What error do you observe? Should we include modules to upgrade too?

Error: ('One or more of the selected modules have already been uninstalled, if you believe this to be an error, you may try again later or contact support.', '')

As far as i've seen it is not needed in upgrade

[sbidoul]

What I mean is that a module is in state to upgrade it must be uninstalled too. So the domain you propose (state=installed) is too restrictive. Do you want to make a PR, with a test ?

[GSLabIt]

What I mean is that a module is in state to upgrade it must be uninstalled too. So the domain you propose (state=installed) is too restrictive. Do you want to make a PR, with a test ?

Oh, I see. so we could use state != 'uninstalled'

[GSLabIt]

What I mean is that a module is in state to upgrade it must be uninstalled too. So the domain you propose (state=installed) is too restrictive. Do you want to make a PR, with a test ?

I'm willing to make a pr, can u help with tests? 😬