Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklistEvents renamed to blacklistIndicators #241

Closed
zebraf1 opened this issue Mar 23, 2020 · 4 comments
Closed

blacklistEvents renamed to blacklistIndicators #241

zebraf1 opened this issue Mar 23, 2020 · 4 comments

Comments

@zebraf1
Copy link

zebraf1 commented Mar 23, 2020

In this commit "polish docs, move to docs dir":

aa88533#diff-5778ab63eb5a74b5b25b27d166c80b32

Algorithm parameter blacklistEvents was renamed to blacklistIndicators without changing the documentation. I understand it was renamed to match the indicators config. Why was doc not updated? I discovered that blacklistEvents were not showing up in engine status and had to check the coding.

See https://actionml.com/docs/h_ur_config#complete-ur-engine-configuration-specification
"blacklistEvents": ["", "", "", ""],

Author @pferrel

@zebraf1
Copy link
Author

zebraf1 commented Mar 23, 2020

Even if using blacklistIndicators parameter, I do not get items filtered:

Sending event user 527739 view item ASSET_11637:
{"event":"view","entityType":"user","entityId":"527739","properties":{},"eventTime":"2020-03-23T18:04:45+02:00","targetEntityType":"item","targetEntityId":"ASSET_11637","eventId":"view-527739-ASSET_11637"}
Response: Complete(HttpResponse(201 Created,List(),HttpEntity.Strict(application/json,{"comment":"UR input processed"}),HttpProtocol(HTTP/1.1)))

Fetching recommendations:
{"num":25,"offset":0,"from":0,"user":527739,"fields" ...
Response: Complete(HttpResponse(200 OK,List(),HttpEntity.Strict(application/json,{"result":[{"item":"ASSET_11640","score":0.0},{"item":"ASSET_17436","score":0.0},{"item":"ASSET_8595","score":0.0},{"item":"EPGSHOW_6613_2","score":0.0},{"item":"ASSET_1243","score":0.0},{"item":"ASSET_11637","score":0.0} ...

Query logging:
com.actionml.engines.ur.URAlgorithm Engine-id: telia_ur. Got query:
URQuery(None,None,None,None,None,None,None,None,None,None,None,Some(25),Some(0),None,None)

That's why query.user is None and user history is not used to filter out blacklisted indicator items.

@zebraf1
Copy link
Author

zebraf1 commented Mar 24, 2020

fields has been renamed to rules in URQuery since PredictionIO upgrade.

@zebraf1
Copy link
Author

zebraf1 commented Mar 24, 2020

My query was using "user" as integer value which caused failure in parseAndValidate.
Passing "user":"527739" resulted in URQuery(Some(527739),None,None,None,None,None,None,None,None,None,None,Some(25),Some(0),None,None)

@zebraf1 zebraf1 closed this as completed Mar 24, 2020
@zebraf1
Copy link
Author

zebraf1 commented Mar 24, 2020

I have updated the docs and created PR: actionml/docs.actionml.com#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant