Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot control target namespace #3798

Open
fernandezcuesta opened this issue Nov 6, 2024 · 1 comment · May be fixed by #3797
Open

Cannot control target namespace #3798

fernandezcuesta opened this issue Nov 6, 2024 · 1 comment · May be fixed by #3797
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers

Comments

@fernandezcuesta
Copy link

What would you like added?

Add the ability to override the destination namespace.

Why is this needed?

Sometimes it's handy to deploy both controller and scaler-set charts under the same Helm umbrella chart.
In such cases, since .Release.Namespace is the one inherited from the umbrella chart, we cannot follow the best practices of having separate namespaces for both controller and scalerset.

Additional context

n/a
@fernandezcuesta fernandezcuesta added community Community contribution enhancement New feature or request needs triage Requires review from the maintainers labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@fernandezcuesta fernandezcuesta linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow namespace overrides fernandezcuesta/actions-runner-controller
1 participant
@fernandezcuesta