Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider naming the generated attestation file attestation.intoto.json or allow users to configure it #62

Open
edgarrmondragon opened this issue May 10, 2024 · 1 comment
Labels
feature-request New feature or request

Comments

@edgarrmondragon
Copy link

edgarrmondragon commented May 10, 2024

This would make it slightly easier for projects to comply with OSSF's Scorecard: https://github.com/ossf/scorecard/blob/7ce8609469289d5f3b1bf5ee3122f42b4e3054fb/docs/checks.md#signed-releases.

The alternative at the moment is for users to override the asset name the file is uploaded with to the release.


I can start a PR if y'all like the idea. If we make it configurable, we'd probably want to follow up with a corresponding PR in actions/attest-build-provenance.

@SRv6d
Copy link

SRv6d commented Oct 28, 2024

Doesn't intoto.jsonl use a different format/schema? I think the scorecard doesn't actually verify attestations but only checks for file existence, meaning even incorrect attestation files/formats would lead to a positive result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants