You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would be nice if there was someway of logging the x-github-request-id header.
It would be helpful to have this in cases where the attempt to get a token from app/installations/<installation_id>/access_tokens fails with a "Network Error" where it fails to reach api.github.com for some reason versus any case when GitHub.com is responding with an error.
The text was updated successfully, but these errors were encountered:
The x-github-request-id header is set on responses. If we cannot reach api.github.com, we do not have the x-github-request-id response header, or am I missing something?
Client requests access token and receives it. In this case the x-github-request-id can be logged.
Client requests access token and receive an error from GitHub. In this case the x-github-request-id can be logged and is super useful for zooming in on logs.
Client makes a request (possibly through some maze of proxies) and receives no response whatsoever. This makes it easier to point at the network as the place to begin troubleshooting.
Many litres of tears and escalations may be saved with this precious knowledge.
For case 2., in case of a request error, it should log the full request + response (with credentials redacted), it's the standard @octokit behavior. Do you have an example build where actions/create-github-app-token failed? It would be helpful to see logs
For case 1., we can add that if it's helpful, pull request welcome
For 3., a similar error should be logged as in 2., only lacking a response property
Would be nice if there was someway of logging the x-github-request-id header.
It would be helpful to have this in cases where the attempt to get a token from app/installations/<installation_id>/access_tokens fails with a "Network Error" where it fails to reach api.github.com for some reason versus any case when GitHub.com is responding with an error.
The text was updated successfully, but these errors were encountered: