Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is my job cancelling when I have 'cancel-in-progress' set to false? #3722

Open
tking16 opened this issue Feb 21, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@tking16
Copy link

tking16 commented Feb 21, 2025

So I have 3 jobs in a workflow, 2 of which share the name concurrency ID

jobs:
############################### BOOT SIMULATORS #########################################
  node1:
    name: Selenium Grid Node 1
    runs-on: [appium-grid-hub]
    timeout-minutes: 250

  node2:
   name: Selenium Grid Node 2
   runs-on: [ios-appium-test-node]
   timeout-minutes: 250
   concurrency:
    group: ios-appium-test-runs
    cancel-in-progress: false


  test:
    needs: [node1, node2]
    #needs: [node1]
    name: Run tests
    runs-on: [appium-grid-hub]
    timeout-minutes: 270
    concurrency:
      group: ios-appium-test-runs
      cancel-in-progress: false

This workflow runs as devs create PRs, seems very frequently that if two jobs are waiting around, one of jobs in the ios-appium-test-runs groups ends up getting cancelled

Image

I don't know how to prevent this, seems it won't cancel if it's in progress, but if a job is from another PR is "Waiting" then it will cancel another (these are PRs from two different branches BTW, I would expect a cancellation if someone pushes to the same branch causing a new run on their PR)

@tking16 tking16 added the bug Something isn't working label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant