Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all Java versions #725

Open
danishnawab opened this issue Jan 17, 2025 · 2 comments · May be fixed by #750
Open

Support all Java versions #725

danishnawab opened this issue Jan 17, 2025 · 2 comments · May be fixed by #750
Labels
feature request New feature or request to improve the current logic

Comments

@danishnawab
Copy link

Description:

The README mentions only the Java versions "8, 11, 16, 17, 21". [1]

Can you please explain the rationale for how it is decided to support a certain version or not?

I would additionally request adding support for all Java versions (at least going forward) because "The Tip & Tail Model of Library Development" [2] recommended by OpenJDK would require popular libraries to be able to build and release against the latest versions (as well as using older versions to verify compatibility of older releases).

[1] https://github.com/actions/setup-java/blob/main/README.md#supported-version-syntax
[2] https://openjdk.org/jeps/14

Justification:

Supporting more Java version will allow even more maintainers and vendors to be able to use this action for their builds.
@danishnawab danishnawab added feature request New feature or request to improve the current logic needs triage labels Jan 17, 2025
@priya-kinthali
Copy link

Hello @danishnawab 👋,
Thank you for this feature request. We will investigate it and get back to you as soon as we have some feedback.


@skateball skateball linked a pull request Feb 11, 2025 that will close this issue
Open
@skateball
Copy link
Contributor

Hi @danishnawab ,
made some small changes on README.md to enhance readabilty
please check https://github.com/actions/setup-java/pull/750/files if this is now easier to understand.
Regards Christian@SapMachine
PS: To me the whole file would need a major rewrite, but this would be one or more other PRs in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue725 read me supported version syntax skateball/setup-java
3 participants
@danishnawab @priya-kinthali @skateball