From d80325cb0e0b6476758089df100614690bac3fce Mon Sep 17 00:00:00 2001 From: Matt Fiddaman Date: Wed, 29 Jan 2025 17:09:19 +0000 Subject: [PATCH] fix tests --- src/app-gocardless/banks/belfius_gkccbebb.js | 1 + src/app-gocardless/banks/integration-bank.js | 5 ++-- src/app-gocardless/banks/lhv-lhvbee22.js | 2 +- src/app-gocardless/banks/nbg_ethngraaxxx.js | 2 +- .../banks/tests/abanca_caglesmm.spec.js | 8 ++---- .../banks/tests/abnamro_abnanl2a.spec.js | 4 +-- .../tests/bancsabadell_bsabesbbb.spec.js | 8 ++---- .../banks/tests/belfius_gkccbebb.spec.js | 1 + .../banks/tests/cbc_cregbebb.spec.js | 2 ++ .../banks/tests/commerzbank_cobadeff.spec.js | 6 ++--- .../banks/tests/fortuneo_ftnofrp1xxx.spec.js | 22 +++++++--------- .../banks/tests/kbc_kredbebb.spec.js | 2 ++ .../banks/tests/lhv-lhvbee22.spec.js | 16 ++---------- .../banks/tests/revolut_revolt21.spec.js | 8 ++---- ...spk_marburg_biedenkopf_heladef1mar.spec.js | 4 +-- .../tests/ssk_dusseldorf_dussdeddxxx.spec.js | 4 +-- .../banks/tests/swedbank_habalv22.spec.js | 9 ++----- .../banks/tests/virgin_nrnbgb22.spec.js | 23 +++++------------ src/app-gocardless/services/tests/fixtures.js | 10 ++++---- .../services/tests/gocardless-service.spec.js | 25 +++++++++++++------ 20 files changed, 67 insertions(+), 95 deletions(-) diff --git a/src/app-gocardless/banks/belfius_gkccbebb.js b/src/app-gocardless/banks/belfius_gkccbebb.js index 344faa47a..5b7ede23c 100644 --- a/src/app-gocardless/banks/belfius_gkccbebb.js +++ b/src/app-gocardless/banks/belfius_gkccbebb.js @@ -11,6 +11,7 @@ export default { // They will set an internalTransactionId which is unique normalizeTransaction(transaction, booked) { transaction.transactionId = transaction.internalTransactionId; + return Fallback.normalizeTransaction(transaction, booked); }, }; diff --git a/src/app-gocardless/banks/integration-bank.js b/src/app-gocardless/banks/integration-bank.js index 0c3578fae..aec69c84f 100644 --- a/src/app-gocardless/banks/integration-bank.js +++ b/src/app-gocardless/banks/integration-bank.js @@ -47,7 +47,7 @@ export default { const trans = editedTransaction ?? transaction; const date = - editedTransaction.date || + trans.date || transaction.bookingDate || transaction.bookingDateTime || transaction.valueDate || @@ -61,8 +61,9 @@ export default { } const notes = + trans.notes ?? trans.remittanceInformationUnstructured ?? - trans.remittanceInformationUnstructuredArray.join(' '); + trans.remittanceInformationUnstructuredArray?.join(' '); transaction.remittanceInformationUnstructuredArrayString = transaction.remittanceInformationUnstructuredArray?.join(','); diff --git a/src/app-gocardless/banks/lhv-lhvbee22.js b/src/app-gocardless/banks/lhv-lhvbee22.js index 52901b5d8..1f3f19664 100644 --- a/src/app-gocardless/banks/lhv-lhvbee22.js +++ b/src/app-gocardless/banks/lhv-lhvbee22.js @@ -24,7 +24,7 @@ export default { if (cardTxMatch) { const extractedDate = d.parse(cardTxMatch[2], 'yyyy-MM-dd', new Date()); - editedTrans.creditorName = cardTxMatch[4].split('\\')[0].trim(); + editedTrans.payeeName = cardTxMatch[4].split('\\')[0].trim(); if (booked && d.isValid(extractedDate)) { editedTrans.date = d.format(extractedDate, 'yyyy-MM-dd'); diff --git a/src/app-gocardless/banks/nbg_ethngraaxxx.js b/src/app-gocardless/banks/nbg_ethngraaxxx.js index 3a5efd790..214591528 100644 --- a/src/app-gocardless/banks/nbg_ethngraaxxx.js +++ b/src/app-gocardless/banks/nbg_ethngraaxxx.js @@ -20,7 +20,7 @@ export default { !transaction.transactionId && transaction.remittanceInformationUnstructured.startsWith('ΑΓΟΡΑ ') ) { - editedTrans.transactionAmount = { + transaction.transactionAmount = { amount: '-' + transaction.transactionAmount.amount, currency: transaction.transactionAmount.currency, }; diff --git a/src/app-gocardless/banks/tests/abanca_caglesmm.spec.js b/src/app-gocardless/banks/tests/abanca_caglesmm.spec.js index 3ceb0817c..c4ea6c867 100644 --- a/src/app-gocardless/banks/tests/abanca_caglesmm.spec.js +++ b/src/app-gocardless/banks/tests/abanca_caglesmm.spec.js @@ -9,17 +9,13 @@ describe('Abanca', () => { internalTransactionId: 'D202301180000003', transactionAmount: mockTransactionAmount, remittanceInformationStructured: 'some-creditor-name', + date: new Date().toISOString(), }; const normalizedTransaction = Abanca.normalizeTransaction( transaction, true, ); - expect(normalizedTransaction.creditorName).toEqual( - transaction.remittanceInformationStructured, - ); - expect(normalizedTransaction.debtorName).toEqual( - transaction.remittanceInformationStructured, - ); + expect(normalizedTransaction.payeeName).toEqual('Some-Creditor-Name'); }); }); }); diff --git a/src/app-gocardless/banks/tests/abnamro_abnanl2a.spec.js b/src/app-gocardless/banks/tests/abnamro_abnanl2a.spec.js index db93bd2c7..fd9b35c5a 100644 --- a/src/app-gocardless/banks/tests/abnamro_abnanl2a.spec.js +++ b/src/app-gocardless/banks/tests/abnamro_abnanl2a.spec.js @@ -24,7 +24,7 @@ describe('AbnamroAbnanl2a', () => { false, ); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( + expect(normalizedTransaction.notes).toEqual( 'BEA, Betaalpas, My Payee Name,PAS123, NR:123A4B, 09.12.23/15:43, CITY', ); expect(normalizedTransaction.payeeName).toEqual('My Payee Name'); @@ -52,7 +52,7 @@ describe('AbnamroAbnanl2a', () => { false, ); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( + expect(normalizedTransaction.notes).toEqual( 'BEA, Google Pay, CCV*Other payee name,PAS123, NR:123A4B, 09.12.23/15:43, CITY', ); expect(normalizedTransaction.payeeName).toEqual('Other Payee Name'); diff --git a/src/app-gocardless/banks/tests/bancsabadell_bsabesbbb.spec.js b/src/app-gocardless/banks/tests/bancsabadell_bsabesbbb.spec.js index 1e7cb9140..9cf1949d1 100644 --- a/src/app-gocardless/banks/tests/bancsabadell_bsabesbbb.spec.js +++ b/src/app-gocardless/banks/tests/bancsabadell_bsabesbbb.spec.js @@ -15,10 +15,7 @@ describe('BancSabadell', () => { transaction, true, ); - expect(normalizedTransaction.creditorName).toEqual( - 'some-creditor-name', - ); - expect(normalizedTransaction.debtorName).toEqual(null); + expect(normalizedTransaction.payeeName).toEqual('Some-Creditor-Name'); }); it('creditor role - amount > 0', () => { @@ -33,8 +30,7 @@ describe('BancSabadell', () => { transaction, true, ); - expect(normalizedTransaction.debtorName).toEqual('some-debtor-name'); - expect(normalizedTransaction.creditorName).toEqual(null); + expect(normalizedTransaction.payeeName).toEqual('Some-Debtor-Name'); }); }); diff --git a/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js b/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js index 25291a6a8..2369809c5 100644 --- a/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js +++ b/src/app-gocardless/banks/tests/belfius_gkccbebb.spec.js @@ -8,6 +8,7 @@ describe('Belfius', () => { transactionId: 'non-unique-id', internalTransactionId: 'D202301180000003', transactionAmount: mockTransactionAmount, + date: new Date().toISOString(), }; const normalizedTransaction = Belfius.normalizeTransaction( transaction, diff --git a/src/app-gocardless/banks/tests/cbc_cregbebb.spec.js b/src/app-gocardless/banks/tests/cbc_cregbebb.spec.js index 4114ac494..21d248a85 100644 --- a/src/app-gocardless/banks/tests/cbc_cregbebb.spec.js +++ b/src/app-gocardless/banks/tests/cbc_cregbebb.spec.js @@ -7,6 +7,7 @@ describe('cbc_cregbebb', () => { remittanceInformationUnstructured: 'ONKART FR Viry Paiement Maestro par Carte de débit CBC 05-09-2024 à 15.43 heures 6703 19XX XXXX X201 5 JOHN DOE', transactionAmount: { amount: '-45.00', currency: 'EUR' }, + date: new Date().toISOString(), }; const normalizedTransaction = CBCcregbebb.normalizeTransaction( transaction, @@ -21,6 +22,7 @@ describe('cbc_cregbebb', () => { remittanceInformationUnstructured: 'ONKART FR Viry Paiement Maestro par Carte de débit CBC 05-09-2024 à 15.43 heures 6703 19XX XXXX X201 5 JOHN DOE', transactionAmount: { amount: '10.99', currency: 'EUR' }, + date: new Date().toISOString(), }; const normalizedTransaction = CBCcregbebb.normalizeTransaction( transaction, diff --git a/src/app-gocardless/banks/tests/commerzbank_cobadeff.spec.js b/src/app-gocardless/banks/tests/commerzbank_cobadeff.spec.js index 9667ce226..fe3a161f6 100644 --- a/src/app-gocardless/banks/tests/commerzbank_cobadeff.spec.js +++ b/src/app-gocardless/banks/tests/commerzbank_cobadeff.spec.js @@ -28,7 +28,7 @@ describe('CommerzbankCobadeff', () => { transaction, false, ); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( + expect(normalizedTransaction.notes).toEqual( '2024-12-19T15:34:31 KFN 1 AB 1234, Kartenzahlung', ); }); @@ -66,7 +66,7 @@ describe('CommerzbankCobadeff', () => { transaction, false, ); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( + expect(normalizedTransaction.notes).toEqual( '901234567890/. Long description tha t gets cut and is very long, did I mention it is long, End-to-End-Ref.: 901234567890, Mandatsref: ABC123DEF456, Gläubiger-ID: AB12CDE0000000000000000012, SEPA-BASISLASTSCHRIFT wiederholend', ); }); @@ -102,7 +102,7 @@ describe('CommerzbankCobadeff', () => { transaction, false, ); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( + expect(normalizedTransaction.notes).toEqual( 'CREDITOR00BIC CREDITOR000IBAN DESCRIPTION, Dauerauftrag', ); }); diff --git a/src/app-gocardless/banks/tests/fortuneo_ftnofrp1xxx.spec.js b/src/app-gocardless/banks/tests/fortuneo_ftnofrp1xxx.spec.js index d4a1b30ff..a19dd3b56 100644 --- a/src/app-gocardless/banks/tests/fortuneo_ftnofrp1xxx.spec.js +++ b/src/app-gocardless/banks/tests/fortuneo_ftnofrp1xxx.spec.js @@ -140,14 +140,12 @@ describe('Fortuneo', () => { true, ); - expect(normalizedCreditorTransaction.creditorName).toBeDefined(); - expect(normalizedCreditorTransaction.debtorName).toBeNull(); + expect(normalizedCreditorTransaction.payeeName).toBeDefined(); expect( parseFloat(normalizedCreditorTransaction.transactionAmount.amount), ).toBeLessThan(0); - expect(normalizedDebtorTransaction.debtorName).toBeDefined(); - expect(normalizedDebtorTransaction.creditorName).toBeNull(); + expect(normalizedDebtorTransaction.payeeName).toBeDefined(); expect( parseFloat(normalizedDebtorTransaction.transactionAmount.amount), ).toBeGreaterThan(0); @@ -160,7 +158,7 @@ describe('Fortuneo', () => { true, ); - expect(normalizedTransaction.creditorName).toBe('ONG'); + expect(normalizedTransaction.payeeName).toBe('Ong'); const transaction2 = transactionsRaw[2]; const normalizedTransaction2 = Fortuneo.normalizeTransaction( @@ -168,7 +166,7 @@ describe('Fortuneo', () => { true, ); - expect(normalizedTransaction2.creditorName).toBe('XXXYYYYZZZ'); + expect(normalizedTransaction2.payeeName).toBe('Xxxyyyyzzz'); const transaction3 = transactionsRaw[3]; const normalizedTransaction3 = Fortuneo.normalizeTransaction( @@ -176,9 +174,7 @@ describe('Fortuneo', () => { true, ); - expect(normalizedTransaction3.creditorName).toBe( - 'Google Payment I Dublin', - ); + expect(normalizedTransaction3.payeeName).toBe('Google Payment I Dublin'); const transaction4 = transactionsRaw[4]; const normalizedTransaction4 = Fortuneo.normalizeTransaction( @@ -186,7 +182,7 @@ describe('Fortuneo', () => { true, ); - expect(normalizedTransaction4.creditorName).toBe('SPORT MARKET'); + expect(normalizedTransaction4.payeeName).toBe('Sport Market'); const transaction5 = transactionsRaw[5]; const normalizedTransaction5 = Fortuneo.normalizeTransaction( @@ -194,7 +190,7 @@ describe('Fortuneo', () => { true, ); - expect(normalizedTransaction5.debtorName).toBe('WEEZEVENT SOMEPLACE'); + expect(normalizedTransaction5.payeeName).toBe('Weezevent Someplace'); const transaction7 = transactionsRaw[7]; const normalizedTransaction7 = Fortuneo.normalizeTransaction( @@ -202,8 +198,8 @@ describe('Fortuneo', () => { true, ); - expect(normalizedTransaction7.creditorName).toBe( - 'Leclerc XXXX Leclerc XXXX 44321IXCRT211141232', + expect(normalizedTransaction7.payeeName).toBe( + 'Leclerc Xxxx Leclerc Xxxx 44321ixcrt211141232', ); }); }); diff --git a/src/app-gocardless/banks/tests/kbc_kredbebb.spec.js b/src/app-gocardless/banks/tests/kbc_kredbebb.spec.js index 21e67dcd3..e3326a12a 100644 --- a/src/app-gocardless/banks/tests/kbc_kredbebb.spec.js +++ b/src/app-gocardless/banks/tests/kbc_kredbebb.spec.js @@ -7,6 +7,7 @@ describe('kbc_kredbebb', () => { remittanceInformationUnstructured: 'CARREFOUR ST GIL BE1060 BRUXELLES Betaling met Google Pay via Debit Mastercard 28-08-2024 om 19.15 uur 5127 04XX XXXX 1637 5853 98XX XXXX 2266 JOHN SMITH', transactionAmount: { amount: '-10.99', currency: 'EUR' }, + date: new Date().toISOString(), }; const normalizedTransaction = KBCkredbebb.normalizeTransaction( transaction, @@ -23,6 +24,7 @@ describe('kbc_kredbebb', () => { remittanceInformationUnstructured: 'CARREFOUR ST GIL BE1060 BRUXELLES Betaling met Google Pay via Debit Mastercard 28-08-2024 om 19.15 uur 5127 04XX XXXX 1637 5853 98XX XXXX 2266 JOHN SMITH', transactionAmount: { amount: '10.99', currency: 'EUR' }, + date: new Date().toISOString(), }; const normalizedTransaction = KBCkredbebb.normalizeTransaction( transaction, diff --git a/src/app-gocardless/banks/tests/lhv-lhvbee22.spec.js b/src/app-gocardless/banks/tests/lhv-lhvbee22.spec.js index 72e61fb38..0f40c49d7 100644 --- a/src/app-gocardless/banks/tests/lhv-lhvbee22.spec.js +++ b/src/app-gocardless/banks/tests/lhv-lhvbee22.spec.js @@ -18,16 +18,11 @@ describe('#normalizeTransaction', () => { it('extracts booked card transaction creditor name', () => { expect( - LhvLhvbee22.normalizeTransaction(bookedCardTransaction, true) - .creditorName, + LhvLhvbee22.normalizeTransaction(bookedCardTransaction, true).payeeName, ).toEqual('CrustumOU'); }); it('extracts booked card transaction date', () => { - expect( - LhvLhvbee22.normalizeTransaction(bookedCardTransaction, true).bookingDate, - ).toEqual('2025-01-02'); - expect( LhvLhvbee22.normalizeTransaction(bookedCardTransaction, true).date, ).toEqual('2025-01-02'); @@ -45,7 +40,6 @@ describe('#normalizeTransaction', () => { }; const normalized = LhvLhvbee22.normalizeTransaction(transaction, true); - expect(normalized.bookingDate).toEqual('2025-01-03'); expect(normalized.date).toEqual('2025-01-03'); }); @@ -62,17 +56,11 @@ describe('#normalizeTransaction', () => { it('extracts pending card transaction creditor name', () => { expect( - LhvLhvbee22.normalizeTransaction(pendingCardTransaction, false) - .creditorName, + LhvLhvbee22.normalizeTransaction(pendingCardTransaction, false).payeeName, ).toEqual('CrustumOU'); }); it('extracts pending card transaction date', () => { - expect( - LhvLhvbee22.normalizeTransaction(pendingCardTransaction, false) - .bookingDate, - ).toEqual(undefined); - expect( LhvLhvbee22.normalizeTransaction(pendingCardTransaction, false).date, ).toEqual('2025-01-03'); diff --git a/src/app-gocardless/banks/tests/revolut_revolt21.spec.js b/src/app-gocardless/banks/tests/revolut_revolt21.spec.js index 40e8bef75..c48e3447b 100644 --- a/src/app-gocardless/banks/tests/revolut_revolt21.spec.js +++ b/src/app-gocardless/banks/tests/revolut_revolt21.spec.js @@ -17,9 +17,7 @@ describe('RevolutRevolt21', () => { true, ); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( - 'Bizum description', - ); + expect(normalizedTransaction.notes).toEqual('Bizum description'); }); }); @@ -39,8 +37,6 @@ describe('RevolutRevolt21', () => { ); expect(normalizedTransaction.payeeName).toEqual('DEBTOR NAME'); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( - 'Bizum description', - ); + expect(normalizedTransaction.notes).toEqual('Bizum description'); }); }); diff --git a/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js b/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js index 7cac1ab81..61401c5fd 100644 --- a/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js +++ b/src/app-gocardless/banks/tests/spk_marburg_biedenkopf_heladef1mar.spec.js @@ -148,7 +148,7 @@ describe('SpkMarburgBiedenkopfHeladef1mar', () => { expect( SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(transaction, true) - .remittanceInformationUnstructured, + .notes, ).toEqual('AUTORISATION 28.12. 18:30'); }); @@ -172,7 +172,7 @@ describe('SpkMarburgBiedenkopfHeladef1mar', () => { expect( SpkMarburgBiedenkopfHeladef1mar.normalizeTransaction(transaction, true) - .remittanceInformationUnstructured, + .notes, ).toEqual('Entgeltabrechnung siehe Anlage'); }); }); diff --git a/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js b/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js index d04f8daea..7693bce25 100644 --- a/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js +++ b/src/app-gocardless/banks/tests/ssk_dusseldorf_dussdeddxxx.spec.js @@ -46,14 +46,14 @@ describe('ssk_dusseldorf_dussdeddxxx', () => { SskDusseldorfDussdeddxxx.normalizeTransaction( bookedTransactionOne, true, - ).remittanceInformationUnstructured, + ).notes, ).toEqual('unstructured information some additional information'); expect( SskDusseldorfDussdeddxxx.normalizeTransaction( bookedTransactionTwo, true, - ).remittanceInformationUnstructured, + ).notes, ).toEqual('structured information some additional information'); }); diff --git a/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js b/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js index 31673a4eb..7fa3c0ad7 100644 --- a/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js +++ b/src/app-gocardless/banks/tests/swedbank_habalv22.spec.js @@ -17,11 +17,6 @@ describe('#normalizeTransaction', () => { }; it('extracts card transaction date', () => { - expect( - SwedbankHabaLV22.normalizeTransaction(bookedCardTransaction, true) - .bookingDate, - ).toEqual('2024-10-28'); - expect( SwedbankHabaLV22.normalizeTransaction(bookedCardTransaction, true).date, ).toEqual('2024-10-28'); @@ -56,7 +51,7 @@ describe('#normalizeTransaction', () => { it('extracts pending card transaction creditor name', () => { expect( SwedbankHabaLV22.normalizeTransaction(pendingCardTransaction, false) - .creditorName, - ).toEqual('SOME CREDITOR NAME'); + .payeeName, + ).toEqual('Some Creditor Name'); }); }); diff --git a/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js b/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js index c6cb6b26c..40a56d738 100644 --- a/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js +++ b/src/app-gocardless/banks/tests/virgin_nrnbgb22.spec.js @@ -15,13 +15,8 @@ describe('Virgin', () => { true, ); - expect(normalizedTransaction.creditorName).toEqual( - 'DIRECT DEBIT PAYMENT', - ); - expect(normalizedTransaction.debtorName).toEqual('DIRECT DEBIT PAYMENT'); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( - 'DIRECT DEBIT PAYMENT', - ); + expect(normalizedTransaction.payeeName).toEqual('Direct Debit Payment'); + expect(normalizedTransaction.notes).toEqual('DIRECT DEBIT PAYMENT'); }); it('formats bank transfer payee and references', () => { @@ -36,11 +31,8 @@ describe('Virgin', () => { true, ); - expect(normalizedTransaction.creditorName).toEqual('Joe Bloggs'); - expect(normalizedTransaction.debtorName).toEqual('Joe Bloggs'); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( - 'Food', - ); + expect(normalizedTransaction.payeeName).toEqual('Joe Bloggs'); + expect(normalizedTransaction.notes).toEqual('Food'); }); it('removes method information from payee name', () => { @@ -55,11 +47,8 @@ describe('Virgin', () => { true, ); - expect(normalizedTransaction.creditorName).toEqual('Tesco Express'); - expect(normalizedTransaction.debtorName).toEqual('Tesco Express'); - expect(normalizedTransaction.remittanceInformationUnstructured).toEqual( - 'Card 99, Tesco Express', - ); + expect(normalizedTransaction.payeeName).toEqual('Tesco Express'); + expect(normalizedTransaction.notes).toEqual('Card 99, Tesco Express'); }); }); }); diff --git a/src/app-gocardless/services/tests/fixtures.js b/src/app-gocardless/services/tests/fixtures.js index 40c34501a..aecf48b69 100644 --- a/src/app-gocardless/services/tests/fixtures.js +++ b/src/app-gocardless/services/tests/fixtures.js @@ -35,8 +35,8 @@ export const mockTransactions = { amount: '328.18', }, bankTransactionCode: 'string', - bookingDate: 'date', - valueDate: 'date', + bookingDate: '2000-01-01', + valueDate: '2000-01-01', }, { transactionId: 'string', @@ -45,8 +45,8 @@ export const mockTransactions = { amount: '947.26', }, bankTransactionCode: 'string', - bookingDate: 'date', - valueDate: 'date', + bookingDate: '2000-01-01', + valueDate: '2000-01-01', }, ], pending: [ @@ -55,7 +55,7 @@ export const mockTransactions = { currency: 'EUR', amount: '947.26', }, - valueDate: 'date', + valueDate: '2000-01-01', }, ], }, diff --git a/src/app-gocardless/services/tests/gocardless-service.spec.js b/src/app-gocardless/services/tests/gocardless-service.spec.js index 081fc85e0..f73a93152 100644 --- a/src/app-gocardless/services/tests/gocardless-service.spec.js +++ b/src/app-gocardless/services/tests/gocardless-service.spec.js @@ -417,42 +417,51 @@ describe('goCardlessService', () => { "booked": [ { "bankTransactionCode": "string", - "bookingDate": "date", - "date": "date", + "bookingDate": "2000-01-01", + "date": "2000-01-01", "debtorAccount": { "iban": "string", }, "debtorName": "string", + "notes": undefined, "payeeName": "String (stri XXX ring)", + "remittanceInformationStructuredArrayString": undefined, + "remittanceInformationUnstructuredArrayString": undefined, "transactionAmount": { "amount": "328.18", "currency": "EUR", }, "transactionId": "string", - "valueDate": "date", + "valueDate": "2000-01-01", }, { "bankTransactionCode": "string", - "bookingDate": "date", - "date": "date", + "bookingDate": "2000-01-01", + "date": "2000-01-01", + "notes": undefined, "payeeName": "", + "remittanceInformationStructuredArrayString": undefined, + "remittanceInformationUnstructuredArrayString": undefined, "transactionAmount": { "amount": "947.26", "currency": "EUR", }, "transactionId": "string", - "valueDate": "date", + "valueDate": "2000-01-01", }, ], "pending": [ { - "date": "date", + "date": "2000-01-01", + "notes": undefined, "payeeName": "", + "remittanceInformationStructuredArrayString": undefined, + "remittanceInformationUnstructuredArrayString": undefined, "transactionAmount": { "amount": "947.26", "currency": "EUR", }, - "valueDate": "date", + "valueDate": "2000-01-01", }, ], },