Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caching #10

Open
ad1992 opened this issue Jul 28, 2024 · 3 comments
Open

Add caching #10

ad1992 opened this issue Jul 28, 2024 · 3 comments
Labels
performance

Comments

@ad1992
Copy link
Owner

ad1992 commented Jul 28, 2024

Add in-memory caching to optimize the perf and enhance the search results.
@KemingHe KemingHe mentioned this issue Jul 29, 2024
Merged
4 tasks
@ad1992
Copy link
Owner Author

ad1992 commented Jul 29, 2024

@KemingHe let's move caching-related changes to a separate PR so it's easy to review and also have caching-specific tests to ensure better context separately.
It's always best to fix one issue per PR so it is easy to revisit later, maintain, and track as well :)

@KemingHe
Copy link
Contributor

KemingHe commented Jul 29, 2024 •
edited
Loading

@ad1992 , ref d21b62b

@KemingHe let's move caching-related changes to a separate PR so it's easy to review and also have caching-specific tests to ensure better context separately.
It's always best to fix one issue per PR so it is easy to revisit later, maintain, and track as well :)

@KemingHe
Copy link
Contributor

Let us know your exact expectations of this task. Currently we only have one sentence to work with:

Add in-memory caching to optimize the perf and enhance the search results.

Before we begin. Thank you. 🌻

ad1992 added a commit that referenced this issue Jul 29, 2024
@KemingHe @ad1992
test(__tests__ dir): added vitest and coverage reporting GitHub Actio…
c98e6aa 
…ns workflow (#8)

* test(__tests__ dir): added vitest and benchmarking to workflow

* test(__tests__): refactored according to feedback.

* chore(index.test.ts): fixed typo.

* feat(Fuzzy.ts): added query result in-mem caching.

Implemented testing for both cache hit and cache miss cases.

done #10

* chore(git): hard reset to only testing implementation.

* test(__tests__/__snapshots/): updated snapshots.

* remove caching related stuff

---------

Co-authored-by: Aakansha Doshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ad1992 @KemingHe