You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That's my bad. Realistically, it's only used for scaling decimal fields, so I think the answer here is to refactor the code so that a 'normal' FieldValue doesn't have all this scaling stuff. Maybe create a ScaledFieldValue? Need to think about that. Then ensure there's only one value thing per (Scaled)FieldValue (not two as we currently have value and raw_value).
The text was updated successfully, but these errors were encountered:
As per #22 there's a bit of potential confusion around the semantics
raw_value
. That is, it could mean:Uint16
) i.e. after callingfrom_registers
.That's my bad. Realistically, it's only used for scaling decimal fields, so I think the answer here is to refactor the code so that a 'normal'
FieldValue
doesn't have all this scaling stuff. Maybe create aScaledFieldValue
? Need to think about that. Then ensure there's only one value thing per(Scaled)FieldValue
(not two as we currently havevalue
andraw_value
).The text was updated successfully, but these errors were encountered: