Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pymodbus decoding #34

Open
kodonnell opened this issue Jan 16, 2021 · 0 comments
Open

Use pymodbus decoding #34

kodonnell opened this issue Jan 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kodonnell
Copy link
Collaborator

This is a much cleaner way of doing decoding to Int16s etc. Use this as less maintenance and simpler code.

Need to think a bit ... may be able to get rid of Field._from_registers and Field._to_registers now since they'll largely just be e.g. decoder.decode_16bit_int etc. May be able to just add a read_contiguous_fields method to the modbus client which just does all the nice things for you, including creating FieldValues. Anyway, worth thinking through, especially if it makes the code internals nicer.

@kodonnell kodonnell added the enhancement New feature or request label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant