Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit object design and inheritance #5

Open
adamsardar opened this issue Sep 6, 2019 · 2 comments
Open

Revisit object design and inheritance #5

adamsardar opened this issue Sep 6, 2019 · 2 comments
Assignees
@adamsardar

Comments

@adamsardar
Copy link
Owner

At current the design of the base object feels far too complex and clunky. 400+lines in the base class.

Review means by which to condense things. Active bindings for type checking? The validators alone use loads of space; the initialisers even more so.
@adamsardar adamsardar self-assigned this Sep 6, 2019
@adamsardar
Copy link
Owner Author

This is a super-set of #1 as much as anything

adamsardar added a commit that referenced this issue Sep 7, 2019
@adamsardar
A more consistent way to collate constraints. fewer methods need to b…
146ec2b 
…e ovridden. Worj on #5
@adamsardar
Copy link
Owner Author

The constant input checking feels clunky; perhaps use active fields as suggested over on the R6 issue board?

r-lib/R6#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsardar adamsardar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamsardar