Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 2.3 prettier changes #49

Open
adamzapasnik opened this issue May 25, 2021 · 6 comments
Open

Handle 2.3 prettier changes #49

adamzapasnik opened this issue May 25, 2021 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@adamzapasnik
Copy link
Owner

No description provided.

@adamzapasnik adamzapasnik added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 25, 2021
@adamzapasnik adamzapasnik self-assigned this May 25, 2021
@Juice10
Copy link

Juice10 commented Oct 4, 2022

Issues thanks to incompatibility of prettier 2.3 and above: #97 #44 #97

@amkisko
Copy link

amkisko commented Jan 18, 2023

Here are some upgrades to 2.8.0, but still failing in tests:
https://github.com/amkisko/prettier-html-templates - all the issues are visible in tests now
https://github.com/amkisko/prettier-plugin-erb - this one is more complex due to changes in prettier and at the moment in tests it always returns 0 bytes output

UPD 27.01.2024: these repositories are removed.

@tmaier
Copy link

tmaier commented Jan 28, 2023

@amkisko great to see this. Does it already make sense for you to share a Work-in-progress (WIP) Pull Request? Maybe in collaboration with @Juice10, who also started a similar Pull Request

@amkisko
Copy link

amkisko commented Jan 30, 2023

@tmaier @Juice10 you are welcome:

It seems that there are some complex problems to solve. :)

@drewlustro
Copy link

Here are some upgrades to 2.8.0, but still failing in tests: amkisko/prettier-html-templates - all the issues are visible in tests now amkisko/prettier-plugin-erb - this one is more complex due to changes in prettier and at the moment in tests it always returns 0 bytes output

Hi @amkisko – why did you delete the amkisko/prettier-html-templates fork?

Did you give up and prettier-plugin-html-erb is the replacement?

@amkisko
Copy link

amkisko commented Jan 27, 2024

Yes, I did, although PRs are still available, no more changes happened after publishing.

There are few better options available:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants