Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-contrib-pageLevelProgress - multiple indicators when switching languages #2368

Closed
guywillis opened this issue Mar 1, 2019 · 6 comments
Labels

Comments

@guywillis
Copy link
Contributor

guywillis commented Mar 1, 2019

Your environment

  • Framework v4, master branch
  • Chrome v72, Mac OSX

Steps to reproduce

Enable PLP, enable PLP indicators (at any level), enable language picker and change languages from the navigation bar.

Expected behaviour

A single plp indicator renders at each level

Actual behaviour

Multiple plp indicators render at each level

Screenshots

screen1

screen2

@NayanKhedkar
Copy link
Member

@NayanKhedkar
Copy link
Member

@guywillis Can you please confirm it?

@guywillis
Copy link
Contributor Author

Thanks @NayanKhedkar, I shall review your change as soon as I can.

@guywillis
Copy link
Contributor Author

Hi @NayanKhedkar,

I have reviewed your amend and encountered a problem.

Use case:

  • I have two courses - course one (C1) has PLP enabled, course two (C2) has PLP disabled
  • I load C1 and can see PLP is active
  • I switch to C2 using LanguagePicker's drawer quick switch
  • C2 is rendering PLP when it shouldn't be

Alternative use case:

  • I load C2 which has PLP disabled so no progress bars render
  • I switch to C1 using LanguagePicker's drawer quick switch
  • C1 is not rendering PLP when it should be

@NayanKhedkar
Copy link
Member

Thanks ! @guywillis okay got it . I need to be try with other ways like @moloko suggested Link

@moloko
Copy link
Contributor

moloko commented Mar 21, 2019

@moloko moloko closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants