Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'noscript)>[rel="stylesheet"]' is not a valid selector #559

Closed
xtianares opened this issue Apr 18, 2023 · 6 comments
Closed

'noscript)>[rel="stylesheet"]' is not a valid selector #559

xtianares opened this issue Apr 18, 2023 · 6 comments

Comments

@xtianares
Copy link

xtianares commented Apr 18, 2023

I tried a few configuration changes but nothing is fixing it so I started removing some of the HTML elements on a test project and found that anytime I have a <link> element on a page it will result to this error:

'noscript)>[rel="stylesheet"]' is not a valid selector
critical({
      base: paths.site.dest,
      inline: true,
      css: [/path/to/css/files],
      penthouse: {
        forceInclude: ['#selector'],
        timeout: 90000,
        pageLoadSkipTimeout: 30000,
        renderWaitTime: 500,
      },
      dimensions: [{
        width: 1400,
        height: 1200
      }]
    })
@diebevares
Copy link

I solved the issue commented:
inline: true

@hlorofos
Copy link

have the same issue with the console (example from the readme)
cat index.html | critical --base test/fixture --inline > index.critical.html

@braco
Copy link

braco commented May 9, 2023

I think Netlify's "netlify-plugin-inline-critical-css" plugin uses this package? It recently started throwing this error and breaking builds.

@bezoerb
Copy link
Collaborator

bezoerb commented May 9, 2023

i guess this needs to be handled upstream in bezoerb/inline-critical#300

@bezoerb
Copy link
Collaborator

bezoerb commented May 9, 2023

can someone please provide a failing example/test for this issue? i tried reproducing the error using inline-critical as well as critical but everything runs smoothly as expected.

@bezoerb
Copy link
Collaborator

bezoerb commented Jan 27, 2024

I'm closing this due to lack of feedback.
Feel free to reopen if there are new insights

@bezoerb bezoerb closed this as completed Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants