Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns mention other Patterns and terms before they appear #114

Open
rps opened this issue Dec 11, 2013 · 2 comments
Open

Patterns mention other Patterns and terms before they appear #114

rps opened this issue Dec 11, 2013 · 2 comments
Labels

Comments

@rps
Copy link
Contributor

rps commented Dec 11, 2013

There are two issues I noticed with the order of patterns in the book:

  1. The Module section mentions the Singleton Pattern, which is not covered for two sections:

"We’ve seen why the Singleton pattern can be valuable"

  1. The Observer section mentions the term Concrete. This is not explicitly defined until Command Patterns, three sections later.

"Concrete classes are best explained in terms of class-based programming languages"

Changing the location of / reference to these terms will improve the presentation of the ideas.

@addyosmani
Copy link
Owner

Thanks for the head's up, @rps. I'll try to address the order so that this makes more sense.

@addyosmani
Copy link
Owner

he Constructor and Prototype patterns are very similar but are separated by five other less closely-related patterns. I think the presentation of these two patterns would be considerably amplified were they presented sequentially, with a discussion of the differences between the new operator and the Object.create method. I think there's also a case to be made for grouping these two directly above Factory, Mixins and Decorators to really drive the ideas home.

from your other reported issue. Will address both in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants