Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump resource version for skupper controller #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump resource version for skupper controller #1

wants to merge 1 commit into from

Conversation

ikke-t
Copy link

@ikke-t ikke-t commented Dec 23, 2022

there is hard coded 0.8.6 version of site-controller image being used here. That lead to problems while I tried the demo. Go had segmentation fault repeatedly, and the demo didn't work:

2022/12/22 15:24:00 Checking if sites need updates (0.8.6)
E1222
 15:24:00.334513       1 runtime.go:78] Observed a panic: "invalid 
memory address or nil pointer dereference" (runtime error: invalid 
memory address or nil pointer dereference)
goroutine 1 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x14a6460, 0x22f4fc0)
    /go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:74 +0xa3
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
    /go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:48 +0x82
panic(0x14a6460, 0x22f4fc0)
    /usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/skupperproject/skupper/pkg/qdr.(*RouterConfig).GetSiteMetadata(...)
    /go/src/app/pkg/qdr/qdr.go:166
github.com/skupperproject/skupper/client.(*VanClient).RouterUpdateVersionInNamespace(0xc000366000,
 0x1877260, 0xc0000c0208, 0x0, 0xc0003b33c0, 0xe, 0xc0000e1dd8, 
0xc0000c6000, 0x26)
    /go/src/app/client/router_update.go:79 +0x129
main.(*SiteController).updateChecks(0xc0003664c0)
    /go/src/app/cmd/site-controller/controller.go:393 +0xff
main.(*SiteController).Run(0xc0003664c0, 0xc00009e660, 0x0, 0x0)
    /go/src/app/cmd/site-controller/controller.go:119 +0x2ee
main.main()
    /go/src/app/cmd/site-controller/main.go:64 +0x1c6
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x132a429]

I found the hard coded version in yaml pointed by kustomize config, and checked the most recent uses :master tagged image. Changed to point to such up to date yaml fixed the issue by upgrading the container.

@ikke-t ikke-t closed this Dec 23, 2022
@ikke-t ikke-t reopened this Dec 23, 2022
@ikke-t
Copy link
Author

ikke-t commented Dec 23, 2022

sorry closed the PR by accident. re-opening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikke-t