Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox labels aren't wrapped in a span anymore #113

Open
makepanic opened this issue May 14, 2018 · 0 comments
Open

Checkbox labels aren't wrapped in a span anymore #113

makepanic opened this issue May 14, 2018 · 0 comments

Comments

@makepanic
Copy link
Contributor

makepanic commented May 14, 2018

I think #95 introduced a regression where checkbox elements don't use a span wrapped label anymore.

https://github.com/adfinis-sygroup/ember-validated-form/pull/95/files#diff-3fdbc85ba77b90bb068fe83da64dee87L85 removed wrapping the checkbox label in a span by introducing a validated-label that is simply echoing the {{label}}.

I think it's my fault for not adding a test that checks that checkbox labels are also wrapped in a span.

There's probably a similar issue where validated-label isn't used for radio inputs. Meaning you can't customize the label there.

There are various possible options to solve this:

  • use validated-label for all label usages in validated-input
  • add span wrapping to validated-label, which means all validated-labels will change or
  • add wrapped attribute to validated-label which will be set to true for uses in checkbox or radio inputs

I can open a PR if we find a solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant