Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keycloak-operator] Customize namespace by property #1273

Open
gwydionmv opened this issue Jun 13, 2024 · 3 comments
Open

[keycloak-operator] Customize namespace by property #1273

gwydionmv opened this issue Jun 13, 2024 · 3 comments

Comments

@gwydionmv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current keycloak-operator chart doesn't allow to specify the namespace for the resources.

Describe the solution you'd like
Include in the metadata section of every resource a new line like
namespace: {{ include "keycloak-operator.operator.namespace" . }}

@hairmare
Copy link
Contributor

hairmare commented Jun 13, 2024

tbh, i never understood the namespace: ... pattern that most charts started using at some point. Do you by any chance know why it's needed? I've never had to use it when installing this chart because doing it via Argo CD or using helm install --namespace <ns> seems to work all the time.

I'll gladly merge it if it's really needed, maybe it should be optional?

{{- with .Values.keycloak.namespace }}
  namespace: {{ . }}
{{- end }}

@gwydionmv
Copy link
Contributor Author

well, we use it because we have different namespaces name depending on the environment, so to automatise the generation and deployment during the CI/CD we need to be able to customise it (we are not using ArgoCD).

I completely agree with the optional line :D

@gwydionmv
Copy link
Contributor Author

I have already push a PR with the changes :D

#1274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants