Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: typescript and glint #313

Open
1 task done
c0rydoras opened this issue Mar 22, 2024 · 0 comments
Open
1 task done

[REFACTOR]: typescript and glint #313

c0rydoras opened this issue Mar 22, 2024 · 0 comments
Assignees
Labels
frontend This issue or pull request is frontend related refactor This issue or pull request discusses refactoring

Comments

@c0rydoras
Copy link
Collaborator

c0rydoras commented Mar 22, 2024

What to refactor

Everything possible should be typescript

Why refactor it

Type Safety + Better DX

How to refactor it

As of right now it makes more sense to work on other things and/or to start by rewriting the addons used e.g. ember-uikit in typescript / writing proper types for that or to use something like frontile instead of ember-uikit.

  1. Setup typescript
  2. Setup glint
  3. Add Signatures to gjs components and rename to gts
  4. Move utils and
  5. Move hbs components to gts
  6. Move templates to gts using https://github.com/discourse/ember-route-template
  7. Type Checking in CI
"scripts": {
   "lint:types": "glint",
}

Do this in multiple Pull Requests and not one large one

Required

  • I have checked past issues to ensure that this isn't a duplicate.
@c0rydoras c0rydoras added frontend This issue or pull request is frontend related refactor This issue or pull request discusses refactoring labels Mar 22, 2024
@c0rydoras c0rydoras self-assigned this Mar 22, 2024
@c0rydoras c0rydoras moved this to Todo in Outdated v1 Mar 22, 2024
@c0rydoras c0rydoras removed this from Outdated v1 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This issue or pull request is frontend related refactor This issue or pull request discusses refactoring
Projects
None yet
Development

No branches or pull requests

1 participant