Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XML assertions #12

Open
1 of 3 tasks
peter279k opened this issue Mar 27, 2019 · 1 comment
Open
1 of 3 tasks

Improve XML assertions #12

peter279k opened this issue Mar 27, 2019 · 1 comment

Comments

@peter279k
Copy link
Collaborator

peter279k commented Mar 27, 2019

Introduction

We have to consider about improving XML assertions.

The official PHPUnit provides the following related XML assertions:

  • assertXmlFileEqualsXmlFile
  • assertXmlStringEqualsXmlFile
  • assertXmlStringEqualsXmlString

I think we can implement following XML assertions:

  • assertIsXmlString and assertIsXmlFile
  • assertXmlStringContainsTag
  • assertXmlStringContainsTagWithAttribute
  • assertXmlStringContainsDeclaration
  • assertXmlStringDeclaration

The missed XML assertions have been implemented because we can assert XML string/file easily/conveniently.

@adhocore, do you have any thought about this?

Any related XML assertions I think are feel free to add and mention on this issue.

  • Bug/Issue
  • Feature request
  • General stuff
@adhocore
Copy link
Owner

perfect, if they are not already in phpunit library we can implement it 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants