-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First activity report fields #55
Conversation
* Stepper is removed for now. We will need to support out of order form entry, which the stepper doesn't support (and can't easily be updated to do so)
* Add skip link * Add navigation landmark * Activity report has proper heading structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for deploying this to sandbox. It was really helpful to be able to play around with the form. I don't think I know enough about FE to give more than a comment review. I did have a question/suggestion about those form consts though. Overall, this looks great!
Very nice! Strong work! 👍 Do you think we could a couple of happy path cucumber tests? Maybe something along the lines of "When I press Activity Reports" I see "New report...." heading; "When I select non-grantee", I see "QRIS System" as an option" in the "Who was this activity for" dropdown. |
Description of change
Kept the form split into separate files even though they all show on the same page to help with readability.
Limitations
How to test
Issue(s)
Checklist