Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample courses do not handle endpoint URLs with a trailing slash #25

Open
thomasturrell opened this issue Nov 26, 2021 · 2 comments
Open

Comments

@thomasturrell
Copy link

Currently the sample courses expect that the endpoint URL does not contain a trailing slash. If the endpoint URL does contain a trailing slash then the course will make requests with URLs that contain double slashes.

For example:

https://example.com/xapi//activities/state?stateId=LMS.LaunchData

(URL shorted for readability)

If the LRS uses a HTTP firewall it will reject requests that contain a double slash.

See issue 710 in the cmi5 repository for more details.

@andyjohnson
Copy link
Contributor

Per the 5/20/22 call, @brianjmiller will resolve with their team.

@brianjmiller
Copy link
Collaborator

This should get resolved once we can get RusticiSoftware/cmi5.js#9 worked through the release process. cmi5.js would need to cut a new release, then bump the dependency in the CATAPULT repo for that library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants