Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueOnly: Support dateTime Range and not only string #444

Open
BirgitBoss opened this issue Jun 30, 2024 · 1 comment
Open

ValueOnly: Support dateTime Range and not only string #444

BirgitBoss opened this issue Jun 30, 2024 · 1 comment
Labels
postponed for next version(s) requires workstream approval strategic decision proposal needs to be prepared in TF spec team specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@BirgitBoss
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
see https://github.com/admin-shell-io/aas-specs-api/pull/222/files#r1653646603

In case of date range it could help to be more precise and define a DateValue:

DateValue: 
  type: string
  format: date-time

Without that every date format could be used and would be be not interoperable.

@BirgitBoss BirgitBoss added this to the V3.1 milestone Jun 30, 2024
@JoergNeidig JoergNeidig added specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally requires workstream approval strategic decision proposal needs to be prepared in TF spec team labels Jul 11, 2024
@BirgitBoss
Copy link
Collaborator Author

BirgitBoss commented Dec 11, 2024

2024-12-11 TF Metamodel

i.e. it is proposed to extend

"RangeValueType": {
      "oneOf": [
        {
          "$ref": "#/definitions/StringValue"
        },
        {
          "$ref": "#/definitions/NumberValue"
        },
        {
          "$ref": "#/definitions/BooleanValue"
        }
      ]
    },

with

"RangeValueType": {
      "oneOf": [
        {
          "$ref": "#/definitions/StringValue"
        },
        {
          "$ref": "#/definitions/NumberValue"
        },
        {
          "$ref": "#/definitions/DateValue"
        },
        {
          "$ref": "#/definitions/BooleanValue"
        }
      ]
    },
    "NumberValue": {
      "type": "string",
      "additionalProperties": false,
     format: date-time
    },

format is supported for JSON schema 2020-12 (see https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-00#rfc.section.7) but not yet in 2019-09. Since we still use 2019-09 we can only introduce it as soon as we decide to switch to JSON schema 2020-12.

postpone this issue

still to be clarified: would this kind of change be backward compatible?

@BirgitBoss BirgitBoss modified the milestones: V3.1, V3.x Dec 11, 2024
@BirgitBoss BirgitBoss added postponed for next version(s) ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream requires workstream approval strategic decision proposal needs to be prepared in TF spec team and removed requires workstream approval strategic decision proposal needs to be prepared in TF spec team ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed for next version(s) requires workstream approval strategic decision proposal needs to be prepared in TF spec team specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

2 participants