Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes and Image layers can not be created #15

Open
dirkschulze opened this issue Aug 15, 2014 · 1 comment
Open

Shapes and Image layers can not be created #15

dirkschulze opened this issue Aug 15, 2014 · 1 comment
Labels

Comments

@dirkschulze
Copy link
Contributor

Under unclassified circumstances, svgOMGeneratorShape an svgOMGeneratorImage can fall through all instances and fails. In this case, inOM doesn't have a shapeBounds property and svgOMG crashes in svgWriter.js.

I need to check the details. I can just imagine that for svgOMGeneratorShape we neither fulfill the requirements for a basic shape (circle, ellipse, rect) nor do have path data.

For image we don't seem to have rawPixels as property and therefor fail.

First, we maybe should mark these svgOMs that do not have a mapping to one of the known types and skip them in svgWriter at least.

Second, identify the actual cause of this problem.

@jhatwich
Copy link
Contributor

is there a specific test file this happens with? please provide steps to repro.

dirkschulze added a commit that referenced this issue Jun 16, 2015
Fixes #12 Arcs angles and precision.
dirkschulze added a commit that referenced this issue Aug 24, 2015
Rename shapeBounds to bounds for generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants