Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateOptimizeImage should support FQDN cross-origin sources #299

Open
auniverseaway opened this issue Dec 1, 2023 · 0 comments
Open

CreateOptimizeImage should support FQDN cross-origin sources #299

auniverseaway opened this issue Dec 1, 2023 · 0 comments
Assignees
@auniverseaway

Comments

@auniverseaway
Copy link
Member

Expected Behaviour

If I pass a fully qualified cross-origin domain into createOptimizedImage it should not remove the origin and assume the image is local to the project.

Actual Behaviour

It only uses pathname to create the optimized image.

Reproduce Scenario (including but not limited to)

I injected a cross-origin image in a card block and card block calls createOptmizeImage.

Steps to Reproduce

Build a synthetic card block with cross-origin / FQDN images and watch the origin get stripped out.

Platform and Version

All
@auniverseaway auniverseaway self-assigned this Dec 1, 2023
auniverseaway added a commit that referenced this issue Dec 1, 2023
@auniverseaway
GH-299 Optimized Off Origin Images
3502e96 
* Allow optimize image to use the supplied origin

Resolves: GH-299
@auniverseaway auniverseaway mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@auniverseaway auniverseaway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-299 Optimize off origin images adobe/aem-boilerplate
1 participant
@auniverseaway