Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Cannot logout and login into another account #34

Closed
tmathern opened this issue May 21, 2020 · 9 comments
Closed

[Windows] Cannot logout and login into another account #34

tmathern opened this issue May 21, 2020 · 9 comments
Assignees

Comments

@tmathern
Copy link
Member

Expected Behaviour

After I logout, I want to be able to login again but with another account.

Actual Behaviour

After logout, on the second login, in Chrome, I don't have a chance to switch account because it goes too fast. Therefore, I'm logged in again, but with the wrong account.

Reproduce Scenario (including but not limited to)

Pre-requisite: Working on Windows, with a Chrome browser opening the login page.

Steps to Reproduce

  • Log into an account using aio auth login
  • Logout using aio auth logout
  • Try to log into another account by changing the email address on login page. On Chrome at least, it reuses previous credentials and you should not have the time to switch account.

Platform and Version

Windows 10, Node 14

Sample Code that illustrates the problem

Logs taken while reproducing problem

What happens on subsequent logins: The "you're logged in" page appears nearly immediately.
1

@tmathern tmathern changed the title Cannot logout and login into another account [Windows] Cannot logout and login into another account May 21, 2020
@meryllblanchet meryllblanchet transferred this issue from adobe/aio-cli May 25, 2020
@meryllblanchet
Copy link
Contributor

Hi @tmathern ,

I am not sure whether this is an issue with the CLI IMS Plugin or with the IMS web app.
Does it help if you clean your cookies / cached files?

@shazron shazron transferred this issue from adobe/aio-cli-plugin-ims May 26, 2020
@shazron
Copy link
Member

shazron commented May 26, 2020

See #32

@tmathern
Copy link
Member Author

Removing all cookies fixes the issue, indeed.

@meryllblanchet
Copy link
Contributor

Thanks for confirming @tmathern !
I don't think that we should do anything else at CLI level.

While as a CLI user I expect to be logged in automatically if I am logged in from the browser, I still feel it weird to be logged out in the browser if I log out from my CLI.

WDYT?

@sarahxxu
Copy link

I agree that the user should not be automatically logged out in the browser by default.

However, it looks like it's not clear (currently) how a user can log out in the current flow without having to manually type in a different URL (experience cloud for instance). Perhaps we should add a logout functionality to the CLI log in UI.

@meryllblanchet
Copy link
Contributor

I like the idea, @shazron what about adding a logout link as suggested by @sarahxxu ?

@shazron
Copy link
Member

shazron commented May 29, 2020

Logout link in the terminal? How would this flow look like

@meryllblanchet
Copy link
Contributor

Nope, in the web UI that pops-up to login and then to confirm that the user has successfully logged in.

@sarahxxu
Copy link

Yes ^ actually -- let's close this topic and do a separate one for UI improvements on this page. I'm connected with our design team to discuss further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants