Add timings to the setting up of the web socket #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For responsiveness timing purposes. The timings are added as response headers to the Web Socket setup process. They include the following data (in milliseconds) ordered by when it happens: * X-1-timing-da-admin-head-duration: Duration of the initial HEAD call on da-admin * X-2-timing-docroom-get-duration: Duration of the time it takes to get the room object * X-4-timing-da-admin-get-duration: Duration of the time it takes to do a GET call on da-admin * X-5-timing-read-state-duration: Duration of time time it takes to read the document state from durable object persistent storage * X-7-timing-setup-websocket-duration: Accumulated time it takes to set up the websocket. Includes X-4 and X-5 * X-9-timing-full-duration: The total duration. Includes all of the above.
LCOV of commit
|
karlpauls
approved these changes
Dec 4, 2024
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For responsiveness timing purposes.
The timings are added as response headers to the Web Socket setup process.
They include the following data (in milliseconds) ordered by when it happens:
Motivation and Context
To investigate where time is spent on occasional slow initial setups.
How Has This Been Tested?
Using the chrome response inspector.
Types of changes
Checklist: