From 9edbe049df401c2fc8697bb941e9594f5b9eba00 Mon Sep 17 00:00:00 2001 From: steve benedick Date: Tue, 3 Dec 2019 15:30:21 -0700 Subject: [PATCH 1/2] #51 - reporting clauthorizationstatus to places --- ACPPlacesMonitor.podspec | 6 +++--- ACPPlacesMonitor/ACPPlacesMonitor.h | 2 +- ACPPlacesMonitor/ACPPlacesMonitorConstants.m | 2 +- Podfile | 8 ++++---- Podfile.lock | 18 +++++++++--------- tests/ACPPlacesMonitorLocationDelegateTests.m | 11 +++++++++++ tests/mocks/ACPPlacesMonitorConstantsTests.h | 2 +- 7 files changed, 30 insertions(+), 19 deletions(-) diff --git a/ACPPlacesMonitor.podspec b/ACPPlacesMonitor.podspec index 49c62e0..50dbd66 100644 --- a/ACPPlacesMonitor.podspec +++ b/ACPPlacesMonitor.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "ACPPlacesMonitor" - s.version = "2.1.1" + s.version = "2.1.2" s.summary = "Places monitor for Adobe Experience Cloud SDK. Written and maintained by Adobe." s.description = <<-DESC The Places monitor provides native geolocation functionality, enabling use of the Places product in the V5 Adobe Experience Cloud SDK. @@ -18,8 +18,8 @@ Pod::Spec.new do |s| s.static_framework = true - s.dependency "ACPCore", ">= 2.3.4" - s.dependency "ACPPlaces", ">= 1.2.0" + s.dependency "ACPCore", ">= 2.3.6" + s.dependency "ACPPlaces", ">= 1.3.0" s.subspec "iOS" do |ios| ios.public_header_files = "ACPPlacesMonitor/ACPPlacesMonitor.h" diff --git a/ACPPlacesMonitor/ACPPlacesMonitor.h b/ACPPlacesMonitor/ACPPlacesMonitor.h index 4a33ad1..28a5a53 100644 --- a/ACPPlacesMonitor/ACPPlacesMonitor.h +++ b/ACPPlacesMonitor/ACPPlacesMonitor.h @@ -12,7 +12,7 @@ // // ACPPlacesMonitor.h -// Places Monitor Version: 2.1.1 +// Places Monitor Version: 2.1.2 // #import diff --git a/ACPPlacesMonitor/ACPPlacesMonitorConstants.m b/ACPPlacesMonitor/ACPPlacesMonitorConstants.m index aa7957a..a7958f0 100644 --- a/ACPPlacesMonitor/ACPPlacesMonitorConstants.m +++ b/ACPPlacesMonitor/ACPPlacesMonitorConstants.m @@ -17,7 +17,7 @@ #import "ACPPlacesMonitorConstants.h" #pragma mark - Monitor Properties -NSString* const ACPPlacesMonitorExtensionVersion = @"2.1.1"; +NSString* const ACPPlacesMonitorExtensionVersion = @"2.1.2"; NSString* const ACPPlacesMonitorExtensionName = @"com.adobe.placesMonitor"; int const ACPPlacesMonitorDefaultMaxMonitoredRegionCount = 20; diff --git a/Podfile b/Podfile index 9fb9342..eabc519 100644 --- a/Podfile +++ b/Podfile @@ -4,12 +4,12 @@ workspace 'ACPPlacesMonitor' project 'ACPPlacesMonitor.xcodeproj' target 'ACPPlacesMonitor_iOS' do - pod 'ACPCore', '>= 2.1.0' - pod 'ACPPlaces', '>= 1.0.0' + pod 'ACPCore', '>= 2.3.6' + pod 'ACPPlaces', '>= 1.3.0' end target 'ACPPlacesMonitor-iOS-unit-tests' do - pod 'ACPCore', '>= 2.1.0' - pod 'ACPPlaces', '>= 1.0.0' + pod 'ACPCore', '>= 2.3.6' + pod 'ACPPlaces', '>= 1.3.0' pod 'OCMock', '3.4.3' end diff --git a/Podfile.lock b/Podfile.lock index 5629424..bf4c84e 100644 --- a/Podfile.lock +++ b/Podfile.lock @@ -2,16 +2,16 @@ PODS: - ACPCore (2.3.6): - ACPCore/iOS (= 2.3.6) - ACPCore/iOS (2.3.6) - - ACPPlaces (1.2.0): - - ACPCore (>= 2.3.2) - - ACPPlaces/iOS (= 1.2.0) - - ACPPlaces/iOS (1.2.0): - - ACPCore (>= 2.3.2) + - ACPPlaces (1.3.0): + - ACPCore (>= 2.3.6) + - ACPPlaces/iOS (= 1.3.0) + - ACPPlaces/iOS (1.3.0): + - ACPCore (>= 2.3.6) - OCMock (3.4.3) DEPENDENCIES: - - ACPCore (>= 2.1.0) - - ACPPlaces (>= 1.0.0) + - ACPCore (>= 2.3.6) + - ACPPlaces (>= 1.3.0) - OCMock (= 3.4.3) SPEC REPOS: @@ -22,9 +22,9 @@ SPEC REPOS: SPEC CHECKSUMS: ACPCore: 1d3a5b79f172de3d998cf63b5c1538da1dd66f33 - ACPPlaces: 35401daa06d6b4bb9cfb91cce62e07d871aa0f10 + ACPPlaces: deef721ad68ce9abb2b547183a0a9ec326454400 OCMock: 43565190abc78977ad44a61c0d20d7f0784d35ab -PODFILE CHECKSUM: e6b5f1a437e9254655924c3febf1f623ef768d43 +PODFILE CHECKSUM: b79127b500aa51cc2fc16181b75acbd1dc0dd69c COCOAPODS: 1.8.4 diff --git a/tests/ACPPlacesMonitorLocationDelegateTests.m b/tests/ACPPlacesMonitorLocationDelegateTests.m index 092ffd1..d8ea524 100644 --- a/tests/ACPPlacesMonitorLocationDelegateTests.m +++ b/tests/ACPPlacesMonitorLocationDelegateTests.m @@ -351,4 +351,15 @@ - (void) testAuthStatusStringDefaultCase { XCTAssertEqual(@"Not Determined", result); } +- (void) testAuthStatusChangeReportedToPlaces { + // setup + id placesMock = OCMClassMock([ACPPlaces class]); + + // test + [_locationDelegate locationManager:_manager didChangeAuthorizationStatus:kCLAuthorizationStatusAuthorizedAlways]; + + // verify + OCMVerify([placesMock setAuthorizationStatus:kCLAuthorizationStatusAuthorizedAlways]); +} + @end diff --git a/tests/mocks/ACPPlacesMonitorConstantsTests.h b/tests/mocks/ACPPlacesMonitorConstantsTests.h index ab564af..bf03bfb 100644 --- a/tests/mocks/ACPPlacesMonitorConstantsTests.h +++ b/tests/mocks/ACPPlacesMonitorConstantsTests.h @@ -18,7 +18,7 @@ #define ACPPlacesMonitorConstantsTests_h #pragma mark - Monitor Properties -static NSString* const ACPPlacesMonitorExtensionVersion_Test = @"2.1.1"; +static NSString* const ACPPlacesMonitorExtensionVersion_Test = @"2.1.2"; static NSString* const ACPPlacesMonitorExtensionName_Test = @"com.adobe.placesMonitor"; static int const ACPPlacesMonitorDefaultMaxMonitoredRegionCount_Test = 20; From eb67b162d5dfefcdef4c31403c73200f244e289b Mon Sep 17 00:00:00 2001 From: Steve Benedick Date: Wed, 4 Dec 2019 08:23:34 -0700 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 962d6b5..49c1289 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +### 2.1.2 (4 Dec, 2019) +- GitHub issue #51 - Call Places API to collect `CLAuthorizationStatus` from device when it changes. + ### 2.1.1 (25 Nov, 2019) - GitHub issue #44 - Fixed import statements for Cocoapods projects using multiple pod projects option.