fix(fieldlabel, helptext): restore overrides (#5865)

Co-authored-by: Cory Dransfeldt <[email protected]>

Author: rise-erpelding

.changeset/bold-ducks-end.md

@@ -0,0 +1,8 @@
+---
+'@spectrum-web-components/field-label': patch
+'@spectrum-web-components/help-text': patch
+---
+
+Fix missing CSS custom property overrides for field-label and help-text components
+
+Previously, these components had empty override files despite having corresponding `--system-*` tokens defined in the system theme bridge. This caused the components to not properly apply size-specific spacing tokens for top and bottom text positioning. The fix adds the missing CSS custom property mappings to ensure proper theming across all component sizes (s, m, l, xl).

.circleci/config.yml

@@ -22,7 +22,7 @@ parameters:
     # 3. Commit this change to the PR branch where the changes exist.
     current_golden_images_hash:
         type: string
-        default: 89cb380330cef18d34c0d4cf893790d9c7167b08
+        default: b88c1b90e553e4f212ad60a5d96abc4dc9ed6be0
     wireit_cache_name:
         type: string
         default: wireit

1st-gen/packages/field-label/src/field-label-overrides.css

@@ -9,3 +9,23 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
+
+:host {
+    --spectrum-field-label-top-to-text: var(--system-field-label-top-to-text);
+    --spectrum-field-label-bottom-to-text: var(--system-field-label-bottom-to-text);
+}
+
+:host([size="s"]) {
+    --spectrum-field-label-top-to-text: var(--system-field-label-top-to-text-small);
+    --spectrum-field-label-bottom-to-text: var(--system-field-label-bottom-to-text-small);
+}
+
+:host([size="l"]) {
+    --spectrum-field-label-top-to-text: var(--system-field-label-top-to-text-large);
+    --spectrum-field-label-bottom-to-text: var(--system-field-label-bottom-to-text-large);
+}
+
+:host([size="xl"]) {
+    --spectrum-field-label-top-to-text: var(--system-field-label-top-to-text-extra-large);
+    --spectrum-field-label-bottom-to-text: var(--system-field-label-bottom-to-text-extra-large);
+}

1st-gen/packages/help-text/src/help-text-overrides.css

@@ -9,3 +9,23 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
+
+:host {
+    --spectrum-helptext-top-to-text: var(--system-helptext-top-to-text);
+    --spectrum-helptext-bottom-to-text: var(--system-helptext-bottom-to-text);
+}
+
+:host([size="s"]) {
+    --spectrum-helptext-top-to-text: var(--system-helptext-top-to-text-small);
+    --spectrum-helptext-bottom-to-text: var(--system-helptext-bottom-to-text-small);
+}
+
+:host([size="l"]) {
+    --spectrum-helptext-top-to-text: var(--system-helptext-top-to-text-large);
+    --spectrum-helptext-bottom-to-text: var(--system-helptext-bottom-to-text-large);
+}
+
+:host([size="xl"]) {
+    --spectrum-helptext-top-to-text: var(--system-helptext-top-to-text-extra-large);
+    --spectrum-helptext-bottom-to-text: var(--system-helptext-bottom-to-text-extra-large);
+}