Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sp-picker and sp-slider do not stop propagation of arrow key events after reacting to those events #5099

Open
1 task done
rubencarvalho opened this issue Feb 18, 2025 · 1 comment

Comments

@rubencarvalho
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Picker, Slider

Description of the requested feature

Opening this issue in behalf of Mukul Sharma.

Picker and Slider components should stop propagation of Arrow keyboard events after reacting to those events.

From the Slack thread discussion:
While we currently don't have a "blanket policy" for this, in this case, it seems reasonable for the slider to stop propagation since handling arrow key events is intrinsic to its functionality.
For other events we expose, consumers can handle them on their end depending on their use case.

Mockups or screenshots

No response

Implementation notes or ideas

Slider and Picker should stop propagation of Arrow key events

@najikahalsema
Copy link
Collaborator

SWC-684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants