Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems installing in an addon #74

Open
seawatts opened this issue May 19, 2017 · 3 comments
Open

Problems installing in an addon #74

seawatts opened this issue May 19, 2017 · 3 comments

Comments

@seawatts
Copy link
Contributor

I'm trying to include this addon inside another addon and it then does not include the bugsnag.js shim

@ghost
Copy link

ghost commented May 25, 2017

Can you describe the use case. Why do you want to install ember-cli-bugsnag by virtue of another addon?

My understanding is that the way to do this generally is to add the dependency through the addon blueprint so that the consuming app can keep control of its dependency versions.

Example implementation here:

https://github.com/zestyzesty/ember-cli-zesty-app-base/blob/master/blueprints/ember-cli-zesty-app-base/index.js#L22

@seawatts
Copy link
Contributor Author

No I'm talking about having a shared addon that you use between multiple applications.
e.x
Web App 1 imports my-shared-addon
Admin App 1 imports my-shared-addon

I want to have addons installed in my-shared-addon that get included in both of those applications. Including settings for those addons. So I only have to setup the bugsnag addon once. I.e. not create two utils/bugsnag.js in web App 1 and admin app 1

@ghost
Copy link

ghost commented Jul 1, 2017

@seawatts are you still having problems? Perhaps we could make an example repo where the utils/bugsnag.js file is not being pulled in. I would imagine that if you put that shared file in the app directory of the addon you will have no problems.

Alternatively you can make this part of the blueprint for the addon, which is something I recommend for config files especially.

If you're happy to close the issue, please do. If not let's work together on a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant