Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Immutable Arrays #151

Open
hhff opened this issue Apr 11, 2016 · 2 comments
Open

Move to Immutable Arrays #151

hhff opened this issue Apr 11, 2016 · 2 comments

Comments

@hhff
Copy link
Collaborator

hhff commented Apr 11, 2016

A concern I have is that Ember Infinity heavily relies on "pushing objects" into arrays. I don't think this is a great approach - as it relies on Ember's pushObjects API staying consistent - the _internalModel stuff is confusing for folks.

Instead I think we should be creating new arrays based on the existing & new data.

@davidgoli also raised some concern about using the store's query object in ember infinity. I agree. David - can you share some of your thoughts here?

@mphasize
Copy link

After watching this EmberConf Talk https://www.youtube.com/watch?v=r2Cq1mUlRk4, I think a switch to Immutable Arrays and replacing the model could be very interesting.
It would also solve an issue I am currently having with updating the meta property of the model – which seems impossible even if I explicitly set it in the afterInfinityModel hook. (Explanation: I am trying to access currentPage information in the template.)

@hhff
Copy link
Collaborator Author

hhff commented Apr 27, 2016

Thanks @mphasize - I saw that talk live and it BLEW my MIND

However, the meta issue you're having isn't related to this. Please open a separate issue and I'll see if I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants