Fix for CUSTOMIZED_SDK_URL path issue #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grinder link, when there is no Grinder link, when there is |
karianna
requested changes
Feb 11, 2025
get.sh
Outdated
| @@ -212,6 +212,9 @@ getBinaryOpenjdk() | |||
| fi | |||
|
|
|||
| if [ "$SDK_RESOURCE" == "nightly" ] && [ "$CUSTOMIZED_SDK_URL" != "" ]; then | |||
| if [[ ! "${CUSTOMIZED_SDK_URL}" =~ /$ ]]; then | |||
| CUSTOMIZED_SDK_URL="${CUSTOMIZED_SDK_URL}/" | |||
llxia
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Thanks @dennycjacob . As mentioned, please fix the indentation. Otherwise, the PR looks good.
This update is a fix for CUSTOMIZED_SDK_URL path . The script adds "/" at the end if it is missing Update indentation in get.sh Fixes: adoptium#5947 Signed-off-by: Denny Chacko Jacob [email protected]
dennycjacob
force-pushed
the
customized_url
branch
from
a558534 to
e9b2a8b
Compare
karianna
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is a fix for CUSTOMIZED_SDK_URL path . The script adds "/" at the end if it is missing
Fixes: #5947
Signed-off-by: Denny Chacko Jacob [email protected]