Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Initial Credentials Causes Update #1213

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

AssahBismarkabah
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah commented Nov 26, 2024

What this PR does / why we need it: The initial credentials feature should not trigger an unnecessary update when only the password has changed for an existing user

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): #819

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@AssahBismarkabah AssahBismarkabah linked an issue Nov 26, 2024 that may be closed by this pull request
@AssahBismarkabah AssahBismarkabah force-pushed the 819-initial-credentials-causes-update branch from f450c7f to aa0d819 Compare November 26, 2024 11:16
@AssahBismarkabah AssahBismarkabah added bug java Pull requests that update Java code labels Nov 26, 2024
@AssahBismarkabah AssahBismarkabah force-pushed the 819-initial-credentials-causes-update branch 3 times, most recently from 9609191 to f56b9cc Compare November 26, 2024 11:42
@AssahBismarkabah AssahBismarkabah force-pushed the 819-initial-credentials-causes-update branch from f56b9cc to 5207d3c Compare November 26, 2024 11:50
Copy link

sonarcloud bot commented Nov 26, 2024

@Thendo20 Thendo20 self-requested a review December 5, 2024 09:02
Copy link
Collaborator

@Thendo20 Thendo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@AssahBismarkabah AssahBismarkabah merged commit 708aff0 into main Dec 9, 2024
14 checks passed
@AssahBismarkabah AssahBismarkabah deleted the 819-initial-credentials-causes-update branch December 9, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug java Pull requests that update Java code
Projects
Development

Successfully merging this pull request may close these issues.

Initial Credentials Causes Update
3 participants