Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OvGame runtime crash since renderer refactor #331

Closed
adriengivry opened this issue Nov 25, 2024 · 0 comments · Fixed by #338
Closed

OvGame runtime crash since renderer refactor #331

adriengivry opened this issue Nov 25, 2024 · 0 comments · Fixed by #338
Labels
Bug Something isn't working Crash Something that causes a crash Critical Something that should be fixed quickly

Comments

@adriengivry
Copy link
Member

Description
OvGame crashes in CompositeRenderer::DrawFrame due to missing output buffer (the game doesn't use framebuffers).

To Reproduce
Steps to reproduce the behavior:

  1. Build the game (temp build)
  2. See error

Expected behavior
The game shouldn't crash. The game should also make use of framebuffers now.

Callstack

OvGame.exe!OvRendering::Core::CompositeRenderer::DrawFrame() Line 43	C++
OvGame.exe!RenderCurrentScene(OvCore::Rendering::SceneRenderer & p_renderer, const OvGame::Core::Context & p_context) Line 80	C++
OvGame.exe!OvGame::Core::Game::Update(float p_deltaTime) Line 114	C++
OvGame.exe!OvGame::Core::Application::Run() Line 28	C++
OvGame.exe!main() Line 22	C++
@adriengivry adriengivry added Bug Something isn't working Critical Something that should be fixed quickly Crash Something that causes a crash labels Nov 25, 2024
@adriengivry adriengivry mentioned this issue Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Crash Something that causes a crash Critical Something that should be fixed quickly
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OvGame not rendering properly Overload-Technologies/Overload
1 participant
@adriengivry